From 08a6cdde6f32b7dd1245929c600cf621c4b90761 Mon Sep 17 00:00:00 2001 From: Paul Gevers Date: Thu, 26 Jul 2018 16:39:35 +0200 Subject: [PATCH] Don't have britney create migration-references itself The initial idea was to do this to bootstrap the baseline, but it turns out that this has the drawback it triggers runs for a package that has a new autopkgtest where it didn't have it in the version in the target suite. It was considered harmless (as it would just have a failing reference), but due to autodep8, package can have a passing result in the target suite while the new autopkgtest is actually broken. Such a package should not be blocked / getting a penalty. The alternative is to make the check here smarter, but as this is only for bootstrapping, lets do that outside of britney proper. --- britney2/policies/autopkgtest.py | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/britney2/policies/autopkgtest.py b/britney2/policies/autopkgtest.py index 66574c5..ad548a8 100644 --- a/britney2/policies/autopkgtest.py +++ b/britney2/policies/autopkgtest.py @@ -747,20 +747,6 @@ class AutopkgtestPolicy(BasePolicy): arch_list.append(arch) arch_list.sort() self.send_test_request(src, arch, trigger, huge=huge) - if self.options.adt_baseline == 'reference': - # Check if we already have a reference for this src on this - # arch (or pending). - try: - self.test_results[REF_TRIG][src][arch] - except KeyError: - try: - arch_list = self.pending_tests[REF_TRIG][src] - if arch not in arch_list: - raise KeyError # fall through - except KeyError: - self.logger.info('Requesting %s autopkgtest on %s to set a reference', - src, arch) - self.send_test_request(src, arch, REF_TRIG, huge=huge) def result_in_baseline(self, src, arch): '''Get the result for src on arch in the baseline