From 0e3d363598df8f0525b35888a9c1b21c1e96b663 Mon Sep 17 00:00:00 2001 From: "Adam D. Barratt" Date: Wed, 11 Sep 2013 19:25:57 +0000 Subject: [PATCH] Add sanity-checking of hints So far we only check that hints which should have version information do (and those which should not do not). Signed-off-by: Adam D. Barratt --- hints.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hints.py b/hints.py index 8971b3a..6586e48 100644 --- a/hints.py +++ b/hints.py @@ -36,6 +36,8 @@ class HintCollection(object): self._hints.append(Hint(hint, user)) class Hint(object): + NO_VERSION = [ 'block', 'block-all', 'block-udeb' ] + def __init__(self, hint, user): self._hint = hint self._user = user @@ -58,6 +60,15 @@ class Hint(object): self._packages = self._packages.split(' ') self._packages = [MigrationItem(x) for x in self._packages] + + self.check() + + def check(self): + for package in self.packages: + if self.type in self.__class__.NO_VERSION: + assert package.version is None, package + else: + assert package.version is not None, package def set_active(self, active): self._active = active