From 301298e8c49cb335434719b7dd47bfee61f82cd9 Mon Sep 17 00:00:00 2001 From: Ivo De Decker Date: Wed, 4 Sep 2019 21:49:22 +0000 Subject: [PATCH] Add comment to clarify smooth update code --- britney2/utils.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/britney2/utils.py b/britney2/utils.py index 52e2412..1012208 100644 --- a/britney2/utils.py +++ b/britney2/utils.py @@ -754,6 +754,15 @@ def find_smooth_updateable_binaries(binaries_to_check, combined = set(smoothbins) combined.add(pkg_id) for rdep in rdeps: + # each dependency clause has a set of possible + # alternatives that can satisfy that dependency. + # if any of them is outside the set of smoothbins, the + # dependency can be satisfied even if this binary was + # removed, so there is no need to keep it around for a + # smooth update + # if not, only this binary can satisfy the dependency, so + # we should keep it around until the rdep is no longer in + # testing for dep_clause in pkg_universe.dependencies_of(rdep): # filter out cruft binaries from unstable, because # they will not be added to the set of packages that