From 30d686164c16537f8bfdb81904e86dd1c9f5bb85 Mon Sep 17 00:00:00 2001 From: Niels Thykier Date: Wed, 6 Aug 2014 20:57:38 +0200 Subject: [PATCH] do_all(): Only sort_actions after recurse runs sort_actions() can be quite expensive and it is wasteful to resort actions after each successful "easy"-hint. Signed-off-by: Niels Thykier --- britney.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/britney.py b/britney.py index e8e46f4..da0f158 100755 --- a/britney.py +++ b/britney.py @@ -2316,7 +2316,7 @@ class Britney(object): lundo = None nuninst_end = None better = True - extra = () # empty tuple + extra = [] if hinttype == "easy" or hinttype == "force-hint": force = hinttype == "force-hint" @@ -2395,10 +2395,10 @@ class Britney(object): self.all_selected += selected if not actions: if recurse: - self.upgrade_me = sorted(extra) + self.upgrade_me = extra + self.sort_actions() else: self.upgrade_me = [x for x in self.upgrade_me if x not in set(selected)] - self.sort_actions() else: self.output_write("FAILED\n") if not lundo: return