From a7b58b76e62ea8e883265e84262de7fb308f14c5 Mon Sep 17 00:00:00 2001 From: Steve Langasek Date: Thu, 7 Oct 2021 01:08:45 -0700 Subject: [PATCH] --print-uninst and --nuninst-cache are not mutually-exclusive This check has been present for a long time but there is no reason for it - there is code elsewhere that explicitly checks for both options being set together and DTRT. And this saves a minute on each britney run to not regenerate uninstallability information that was just generated. --- britney.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/britney.py b/britney.py index 3f21937..b5deff2 100755 --- a/britney.py +++ b/britney.py @@ -446,11 +446,8 @@ class Britney(object): pass # integrity checks - if self.options.nuninst_cache and self.options.print_uninst: # pragma: no cover - self.logger.error("nuninst_cache and print_uninst are mutually exclusive!") - sys.exit(1) # if the configuration file exists, then read it and set the additional options - elif not os.path.isfile(self.options.config): # pragma: no cover + if not os.path.isfile(self.options.config): # pragma: no cover self.logger.error("Unable to read the configuration file (%s), exiting!", self.options.config) sys.exit(1)