Lubuntu/britney2-ubuntu
8
0
Fork 0
mirror of https://git.launchpad.net/~ubuntu-release/britney/+git/britney2-ubuntu synced 2025-06-08 16:21:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Abort when do_all fails without transaction to rollback

Browse Source 
When do_all fails, and there is no transaction to rollback, we will probably
leave a broken state behind. This codepath probably isn't triggered unless
something else is broken.

Signed-off-by: Ivo De Decker <ivodd@debian.org>
This commit is contained in:
Ivo De Decker 2019-09-14 10:51:41 +00:00
parent 4de569114a
commit 4defca4cc1
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
britney.py
View File

@ -1098,7 +1098,10 @@ class Britney(object):
else: else:
output_logger.info("FAILED\n") output_logger.info("FAILED\n")
if not transaction: if not transaction:
return # if we 'FAILED', but we cannot rollback, we will probably
# leave a broken state behind
# this should not happen
raise AssertionError("do_all FAILED but no transaction to rollback")
transaction.rollback() transaction.rollback()
if self.options.check_consistency_level >= 2: if self.options.check_consistency_level >= 2:
target_suite.check_suite_source_pkg_consistency('do_all after rollback') target_suite.check_suite_source_pkg_consistency('do_all after rollback')