From 50e0bc137db3d0c4e5cde1a565b27385226b7947 Mon Sep 17 00:00:00 2001 From: Celso Providelo Date: Fri, 20 Feb 2015 17:02:00 -0200 Subject: [PATCH] Add 'boottest' excuse failure reason when it has failed even if the previous tests had already failed. --- britney.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/britney.py b/britney.py index 4599011..becd35c 100755 --- a/britney.py +++ b/britney.py @@ -1976,12 +1976,13 @@ class Britney(object): # Block promotion if the excuse is still valid (adt tests # passed) but the boottests attempt has failed or still in # progress. - if excuse.is_valid and status not in BootTest.VALID_STATUSES: - excuse.is_valid = False - excuse.addhtml("Not considered") + if status not in BootTest.VALID_STATUSES: excuse.addreason("boottest") - upgrade_me.remove(excuse.name) - unconsidered.append(excuse.name) + if excuse.is_valid: + excuse.is_valid = False + excuse.addhtml("Not considered") + upgrade_me.remove(excuse.name) + unconsidered.append(excuse.name) # invalidate impossible excuses for e in self.excuses: