Lubuntu/britney2-ubuntu
8
0
Fork 0
mirror of https://git.launchpad.net/~ubuntu-release/britney/+git/britney2-ubuntu synced 2025-05-23 08:21:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't allow unversioned migrationitems to be hashed

Browse Source 
Unversioned migration items match different versioned items for the same
source, so hashing them will not produce a correct result.

Closes: #945471
This commit is contained in:
Ivo De Decker 2020-01-16 16:21:22 +00:00
parent 18f71a01f5
commit 62c309da07
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
britney2/hints.py
View File

@ -83,7 +83,8 @@ class Hint(object):
if self.type != other.type: if self.type != other.type:
return False return False
else: else:
return frozenset(self.packages) == frozenset(other.packages) # we can't use sets, because unversioned items cannot be hashed
return sorted(self.packages) == sorted(other.packages)
@property @property
def type(self): def type(self):

4
britney2/migrationitem.py
View File

@ -76,6 +76,10 @@ class MigrationItem(object):
return isequal return isequal
def __hash__(self): def __hash__(self):
if not self.version:
raise AssertionError("trying to hash unversioned MigrationItem: %s" %
(self.name))
return hash((self.uvname, self.version)) return hash((self.uvname, self.version))
def __lt__(self, other): def __lt__(self, other):