Lubuntu/britney2-ubuntu
8
0
Fork 0
mirror of https://git.launchpad.net/~ubuntu-release/britney/+git/britney2-ubuntu synced 2025-07-25 15:31:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Assert that binaries have sensible arch values

Browse Source 
Add a check to ensure we do not create broken test data (as happened
recently, where the architecture values were swapped for a single
binary).  A cold hard failure like this is easier to debug
compared to Britney playing "garbage in, garbage out".

Signed-off-by: Niels Thykier <niels@thykier.net>
This commit is contained in:
Niels Thykier 2016-11-13 08:59:49 +00:00
parent 20c2b87833
commit 6360daf8c5
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
britney.py
View File

@ -970,11 +970,16 @@ class Britney(object):
else: else:
provides = [] provides = []
raw_arch = intern(get_field('Architecture'))
if raw_arch not in {'all', arch}: # pragma: no cover
raise AssertionError("%s has wrong architecture (%s) - should be either %s or all" % (
str(pkg_id), raw_arch, arch))
dpkg = BinaryPackage(version, dpkg = BinaryPackage(version,
intern(get_field('Section')), intern(get_field('Section')),
source, source,
source_version, source_version,
intern(get_field('Architecture')), raw_arch,
get_field('Multi-Arch'), get_field('Multi-Arch'),
deps, deps,
', '.join(final_conflicts_list) or None, ', '.join(final_conflicts_list) or None,