From 7d758760d1c08bcd3b364f7e6ec76b2c0eafe68a Mon Sep 17 00:00:00 2001 From: Niels Thykier Date: Sat, 22 Dec 2018 20:48:28 +0000 Subject: [PATCH] MigrationManager: _transaction is a stack; not a queue Correct the return value of current_transaction that treated the _transaction field incorrectly as a queue rather than a stack like everything else. This completely broke the ability to commit and rollback child transactions (correctly). Fortunately, it could only trigger on a "hint"-hint. Signed-off-by: Niels Thykier --- britney2/migration.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/britney2/migration.py b/britney2/migration.py index 8b4488c..72efca1 100644 --- a/britney2/migration.py +++ b/britney2/migration.py @@ -47,7 +47,7 @@ class MigrationManager(object): @property def current_transaction(self): - return self._transactions[0] if self._transactions else None + return self._transactions[-1] if self._transactions else None def compute_groups(self, item,