Apply policy to srcarch excuses

Currently no policy implements this.

A policy can now implement apply_src_policy_impl or apply_srcarch_policy_impl
(or both), so apply_src_policy_impl is no longer an abstractmethod.

Signed-off-by: Ivo De Decker <ivodd@debian.org>

britney.py

@@ -1031,6 +1031,8 @@ class Britney(object):
         if anywrongver:
             excuse.policy_verdict = PolicyVerdict.REJECTED_PERMANENTLY
 
+        self._policy_engine.apply_srcarch_policies(source_suite, src, arch, source_t, source_u, excuse)
+
         self.excuses[excuse.name] = excuse
         return excuse.is_valid
 

britney2/policies/policy.py

@@ -2,7 +2,6 @@ import json
 import logging
 import os
 import time
-from abc import abstractmethod
 from urllib.parse import quote
 
 import apt_pkg
@@ -46,6 +45,18 @@ class PolicyEngine(object):
                     policy_verdict = v
         excuse.policy_verdict = policy_verdict
 
+    def apply_srcarch_policies(self, source_suite, src, arch, source_t, source_u, excuse):
+        policy_verdict = excuse.policy_verdict
+        policy_info = excuse.policy_info
+        suite_name = source_suite.name
+        suite_class = source_suite.suite_class
+        for policy in self._policies:
+            if suite_class in policy.applicable_suites:
+                v = policy.apply_srcarch_policy(policy_info, suite_name, src, arch, source_t, source_u, excuse)
+                if v.value > policy_verdict.value:
+                    policy_verdict = v
+        excuse.policy_verdict = policy_verdict
+
 
 class BasePolicy(object):
 
@@ -108,7 +119,6 @@ class BasePolicy(object):
         pinfo['verdict'] = verdict.name
         return verdict
 
-    @abstractmethod
     def apply_src_policy_impl(self, policy_info, suite, source_name, source_data_tdist, source_data_srcdist, excuse):  # pragma: no cover
         """Apply a policy on a given source migration
 
@@ -135,7 +145,45 @@ class BasePolicy(object):
 
         :return A Policy Verdict (e.g. PolicyVerdict.PASS)
         """
-        pass
+        return PolicyVerdict.PASS
+
+    def apply_srcarch_policy(self, general_policy_info, suite, source_name, arch, source_data_tdist, source_data_srcdist, excuse):
+        pinfo = {}
+        general_policy_info[self.policy_id] = pinfo
+        verdict = self.apply_srcarch_policy_impl(pinfo, suite, source_name, arch, source_data_tdist, source_data_srcdist, excuse)
+        # The base policy provides this field, so the subclass should leave it blank
+        assert 'verdict' not in pinfo
+        pinfo['verdict'] = verdict.name
+        return verdict
+
+    def apply_srcarch_policy_impl(self, policy_info, suite, source_name, arch, source_data_tdist, source_data_srcdist, excuse):
+        """Apply a policy on a given binary migration
+
+        Britney will call this method on binaries from a given source package
+        on a given architecture, when Britney is considering to migrate them
+        from the given source suite to the target suite.  The policy will then
+        evaluate the the migration and then return a verdict.
+
+        :param policy_info A dictionary of all policy results.  The
+        policy can add a value stored in a key related to its name.
+        (e.g. policy_info['age'] = {...}).  This will go directly into
+        the "excuses.yaml" output.
+
+        :param suite The name of the suite from where the source is
+        migrating from.
+
+        :param source_data_tdist Information about the source package
+        in the target distribution (e.g. "testing").  This is the
+        data structure in source_suite.sources[source_name]
+
+        :param source_data_srcdist Information about the source
+        package in the source distribution (e.g. "unstable" or "tpu").
+        This is the data structure in target_suite.sources[source_name]
+
+        :return A Policy Verdict (e.g. PolicyVerdict.PASS)
+        """
+        # if the policy doesn't implement this function, assume it's OK
+        return PolicyVerdict.PASS
 
 
 class SimplePolicyHint(Hint):