From 8ab7fc0e89a5792536af1ffcecaba63510054ea5 Mon Sep 17 00:00:00 2001 From: Niels Thykier Date: Sat, 26 Mar 2016 18:42:52 +0000 Subject: [PATCH] Avoid some unnecessary effort in compuing "affected" * A package being removed is *not* affected - It will just be filtered out later in "check_packages" * Since all transitive reverse dependencies will be added to "affected" at the end of the method, there is no reason to find the immediate set of reverse dependencies of a package if the package is added itself as well. Signed-off-by: Niels Thykier --- britney.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/britney.py b/britney.py index f9616a6..365fe3c 100755 --- a/britney.py +++ b/britney.py @@ -2133,7 +2133,6 @@ class Britney(object): if pkey not in eqv_set: # all the reverse dependencies are affected by # the change - affected.update(inst_tester.reverse_dependencies_of(rm_pkg_id)) affected.update(inst_tester.negative_dependencies_of(rm_pkg_id)) @@ -2163,7 +2162,6 @@ class Britney(object): version = binaries_t_a[item.package][VERSION] pkg_id = (item.package, version, item.architecture) undo['binaries'][(item.package, item.architecture)] = pkg_id - affected.add(pkg_id) affected.update(inst_tester.reverse_dependencies_of(pkg_id)) del binaries_t_a[item.package] inst_tester.remove_testing_binary(pkg_id) @@ -2192,10 +2190,8 @@ class Britney(object): # save the old binary package undo['binaries'][key] = old_pkg_id if not equivalent_replacement: - # all the reverse dependencies are affected by - # the change - affected.update(inst_tester.reverse_dependencies_of(old_pkg_id)) # all the reverse conflicts + affected.update(inst_tester.reverse_dependencies_of(old_pkg_id)) affected.update(inst_tester.negative_dependencies_of(old_pkg_id)) inst_tester.remove_testing_binary(old_pkg_id) elif hint_undo: @@ -2230,7 +2226,6 @@ class Britney(object): if not equivalent_replacement: # all the reverse dependencies are affected by the change affected.add(updated_pkg_id) - affected.update(inst_tester.reverse_dependencies_of(updated_pkg_id)) affected.update(inst_tester.negative_dependencies_of(updated_pkg_id)) # add/update the source package