From acec4ff6e37815cda91517725bc8ffeae778b900 Mon Sep 17 00:00:00 2001 From: "Adam D. Barratt" Date: Wed, 6 Feb 2013 19:09:04 +0000 Subject: [PATCH] Use any() in tpu o-o-d checks rather than throwaway lists The test only needs to consider whether any binaries exist on a given arch, not how many of them there are (or indeed which binaries they are) Signed-off-by: Adam D. Barratt --- britney.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/britney.py b/britney.py index ca9209b..4edce54 100755 --- a/britney.py +++ b/britney.py @@ -1371,17 +1371,17 @@ class Britney(object): # if the package in testing has no binaries on this # architecture, it can't be out-of-date - if (len([x for x in self.sources["testing"][src][BINARIES] - if x.endswith("/"+arch) and self.binaries["testing"][arch][0][x.split("/")[0]][ARCHITECTURE] != 'all' ]) == 0): + if not any(x for x in self.sources["testing"][src][BINARIES] + if x.endswith("/"+arch) and self.binaries["testing"][arch][0][x.split("/")[0]][ARCHITECTURE] != 'all'): continue # if the (t-)p-u package has produced any binaries on # this architecture then we assume it's ok. this allows for # uploads to (t-)p-u which intentionally drop binary # packages - if (len([x for x in self.binaries[suite][arch][0].values() \ - if x[SOURCE] == src and x[SOURCEVER] == source_u[VERSION] and \ - x[ARCHITECTURE] != 'all' ]) > 0): + if any(x for x in self.binaries[suite][arch][0].values() \ + if x[SOURCE] == src and x[SOURCEVER] == source_u[VERSION] and \ + x[ARCHITECTURE] != 'all'): continue if suite == 'tpu':