From b61e1086bdb9b4bd6c3fe47b92a640481a282b5c Mon Sep 17 00:00:00 2001 From: Niels Thykier Date: Sat, 19 Jan 2019 18:06:55 +0000 Subject: [PATCH] solver: Invert an if-statement to reduce max indentation level Signed-off-by: Niels Thykier --- britney2/installability/solver.py | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/britney2/installability/solver.py b/britney2/installability/solver.py index 7837335..6e23f7d 100644 --- a/britney2/installability/solver.py +++ b/britney2/installability/solver.py @@ -267,18 +267,20 @@ class InstallabilitySolver(object): scc_id = com[0] scc[scc_id] = com merged[scc_id] = scc_id - if len(com) > 1: - so_before = order[scc_id]['before'] - so_after = order[scc_id]['after'] - for n in com: - if n == scc_id: - continue - so_before.update(order[n]['before']) - so_after.update(order[n]['after']) - merged[n] = scc_id - del order[n] - if debug_solver: # pragma: no cover - self.logger.debug("SCC: %s -- %s", scc_id, str(sorted(com))) + if len(com) < 2: + # Trivial case + continue + so_before = order[scc_id]['before'] + so_after = order[scc_id]['after'] + for n in com: + if n == scc_id: + continue + so_before.update(order[n]['before']) + so_after.update(order[n]['after']) + merged[n] = scc_id + del order[n] + if debug_solver: # pragma: no cover + self.logger.debug("SCC: %s -- %s", scc_id, str(sorted(com))) for com in comps: node = com[0]