Lubuntu/britney2-ubuntu
8
0
Fork 0
mirror of https://git.launchpad.net/~ubuntu-release/britney/+git/britney2-ubuntu synced 2025-11-04 10:34:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

test-builder: Avoid allocating empty throw-away lists on empty relations

Browse Source 
Signed-off-by: Niels Thykier <niels@thykier.net>
This commit is contained in:
Niels Thykier 2018-08-12 14:09:10 +00:00
parent 373f7f51f3
commit b6888c2716
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
britney2/installability/builder.py
View File

@ -37,13 +37,8 @@ def build_installability_tester(suite_info, archs):
in_testing=is_target):
continue
depends = []
conflicts = []
possible_dep_ranges = {}
# We do not differentiate between depends and pre-depends
if pkgdata.conflicts:
conflicts = []
conflicts_parsed = apt_pkg.parse_depends(pkgdata.conflicts, False)
# Breaks/Conflicts are so simple that we do not need to keep align the relation
# with the suite. This enables us to do a few optimizations.
@ -52,8 +47,12 @@ def build_installability_tester(suite_info, archs):
# if a package satisfies its own conflicts relation, then it is using §7.6.2
conflicts.extend(s.pkg_id for s in solvers(block, dep_binaries_s_a, dep_provides_s_a)
if s.pkg_id != pkg_id)
else:
conflicts = None
if pkgdata.depends:
depends = []
possible_dep_ranges = {}
for block in apt_pkg.parse_depends(pkgdata.depends, False):
sat = {s.pkg_id for binaries_s_a, provides_s_a in bin_prov
for s in solvers(block, binaries_s_a, provides_s_a)}
@ -88,6 +87,8 @@ def build_installability_tester(suite_info, archs):
if possible_dep_ranges:
depends.extend(possible_dep_ranges.values())
else:
depends = None
builder.set_relations(pkg_id, depends, conflicts)