Lubuntu/britney2-ubuntu
8
0
Fork 0
mirror of https://git.launchpad.net/~ubuntu-release/britney/+git/britney2-ubuntu synced 2025-06-05 14:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

solver: Split _compute_group_order into three methods

Browse Source 
Signed-off-by: Niels Thykier <niels@thykier.net>
This commit is contained in:
Niels Thykier 2019-01-19 17:32:17 +00:00
parent c65b377c5d
commit d3e06fc45f
No known key found for this signature in database
GPG Key ID: A65B78DBE67C7AAC
1 changed files with 71 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

132
britney2/installability/solver.py
View File

@ -141,8 +141,76 @@ class InstallabilitySolver(object):
logger_name = ".".join((self.__class__.__module__, self.__class__.__name__)) logger_name = ".".join((self.__class__.__module__, self.__class__.__name__))
self.logger = logging.getLogger(logger_name) self.logger = logging.getLogger(logger_name)
def _compute_group_order(self, groups, key2item): def _compute_group_order_rms(self, rms, order, key, ptable, going_out):
sat_in_testing = self._inst_tester.any_of_these_are_in_the_suite sat_in_testing = self._inst_tester.any_of_these_are_in_the_suite
universe = self._universe
debug_solver = self.logger.isEnabledFor(logging.DEBUG)
for r in rms:
# The binaries have reverse dependencies in testing;
# check if we can/should migrate them first.
for rdep in universe.reverse_dependencies_of(r):
for depgroup in universe.dependencies_of(rdep):
rigid = depgroup - going_out
if sat_in_testing(rigid):
# (partly) satisfied by testing, assume it is okay
continue
if rdep in ptable:
other = ptable[rdep]
if other == key:
# "Self-dependency" => ignore
continue
if debug_solver and other not in order[key]['after']: # pragma: no cover
self.logger.debug("Removal induced order: %s before %s", key, other)
order[key]['after'].add(other)
order[other]['before'].add(key)
def _compute_group_order_adds(self, adds, order, key, ptable, going_out, going_in):
sat_in_testing = self._inst_tester.any_of_these_are_in_the_suite
universe = self._universe
debug_solver = self.logger.isEnabledFor(logging.DEBUG)
for a in adds:
# Check if this item should migrate before others
# (e.g. because they depend on a new [version of a]
# binary provided by this item).
for depgroup in universe.dependencies_of(a):
rigid = depgroup - going_out
if sat_in_testing(rigid):
# (partly) satisfied by testing, assume it is okay
continue
# okay - we got three cases now.
# - "swap" (replace existing binary with a newer version)
# - "addition" (add new binary without removing any)
# - "removal" (remove binary without providing a new)
#
# The problem is that only the two latter requires
# an ordering. A "swap" (in itself) should not
# affect us.
other_adds = set()
other_rms = set()
for d in ifilter_only(ptable, depgroup):
other = ptable[d]
if d in going_in:
# "other" provides something "key" needs,
# schedule accordingly.
other_adds.add(other)
else:
# "other" removes something "key" needs,
# schedule accordingly.
other_rms.add(other)
for other in (other_adds - other_rms):
if debug_solver and other != key and other not in order[key]['after']: # pragma: no cover
self.logger.debug("Dependency induced order (add): %s before %s", key, other)
order[key]['after'].add(other)
order[other]['before'].add(key)
for other in (other_rms - other_adds):
if debug_solver and other != key and other not in order[key]['before']: # pragma: no cover
self.logger.debug("Dependency induced order (remove): %s before %s", key, other)
order[key]['before'].add(other)
order[other]['after'].add(key)
def _compute_group_order(self, groups, key2item):
universe = self._universe universe = self._universe
ptable = {} ptable = {}
order = {} order = {}
@ -194,66 +262,8 @@ class InstallabilitySolver(object):
order[key]['before'].add(other) order[key]['before'].add(other)
order[other]['after'].add(key) order[other]['after'].add(key)
for r in rms: self._compute_group_order_rms(rms, order, key, ptable, going_out)
# The binaries have reverse dependencies in testing; self._compute_group_order_adds(adds, order, key, ptable, going_out, going_in)
# check if we can/should migrate them first.
for rdep in universe.reverse_dependencies_of(r):
for depgroup in universe.dependencies_of(rdep):
rigid = depgroup - going_out
if sat_in_testing(rigid):
# (partly) satisfied by testing, assume it is okay
continue
if rdep in ptable:
other = ptable[rdep]
if other == key:
# "Self-dependency" => ignore
continue
if debug_solver and other not in order[key]['after']: # pragma: no cover
self.logger.debug("Removal induced order: %s before %s", key, other)
order[key]['after'].add(other)
order[other]['before'].add(key)
for a in adds:
# Check if this item should migrate before others
# (e.g. because they depend on a new [version of a]
# binary provided by this item).
for depgroup in universe.dependencies_of(a):
rigid = depgroup - going_out
if sat_in_testing(rigid):
# (partly) satisfied by testing, assume it is okay
continue
# okay - we got three cases now.
# - "swap" (replace existing binary with a newer version)
# - "addition" (add new binary without removing any)
# - "removal" (remove binary without providing a new)
#
# The problem is that only the two latter requires
# an ordering. A "swap" (in itself) should not
# affect us.
other_adds = set()
other_rms = set()
for d in ifilter_only(ptable, depgroup):
other = ptable[d]
if d in going_in:
# "other" provides something "key" needs,
# schedule accordingly.
other_adds.add(other)
else:
# "other" removes something "key" needs,
# schedule accordingly.
other_rms.add(other)
for other in (other_adds - other_rms):
if debug_solver and other != key and other not in order[key]['after']: # pragma: no cover
self.logger.debug("Dependency induced order (add): %s before %s", key, other)
order[key]['after'].add(other)
order[other]['before'].add(key)
for other in (other_rms - other_adds):
if debug_solver and other != key and other not in order[key]['before']: # pragma: no cover
self.logger.debug("Dependency induced order (remove): %s before %s", key, other)
order[key]['before'].add(other)
order[other]['after'].add(key)
return order return order