Lubuntu/britney2-ubuntu
8
0
Fork 0
mirror of https://git.launchpad.net/~ubuntu-release/britney/+git/britney2-ubuntu synced 2025-04-02 13:51:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: check database checksum instead of content-length header

Browse Source 
autopkgtest-cloud will now serve:
autopkgtest.ubuntu.com/static/autopkgtest.db.sha256

Britney now calculates the sha256 of the newly downloaded db locally and
checks that it matches the sha256 file served by autopkgtest-cloud,
instead of checking that the content-length header matches the
size of the new downloaded database.

Since the most recent apache2 security update in focal [1], the
content-length header isn't served by default, and it seems that when
it is served it's not entirely accurate. This check has become
brittle, and so we have implemented this new mechanism.

[1] https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/2061816
This commit is contained in:
Tim Andersson 2024-04-24 10:04:53 +01:00
parent 62aa68142d
commit d5c0c1fbb3
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
britney2/policies/autopkgtest.py
View File

@ -30,6 +30,7 @@ import re
import socket
import sqlite3
import sys
import hashlib
import time
import urllib.parse
from urllib.error import HTTPError
@ -169,8 +170,10 @@ class AutopkgtestPolicy(BasePolicy):
def fetch_db(self):
f = None
local_db_sha = hashlib.sha256()
try:
f = self.download_retry(self.options.adt_db_url)
chksum = self.download_retry(self.options.adt_db_url + ".sha256").read().rstrip()
http_code = f.getcode()
# file:/// urls don't have the http niceties
if not http_code or http_code == 200:
@ -180,10 +183,10 @@ class AutopkgtestPolicy(BasePolicy):
data=f.read(2048*1024)
if not data:
break
local_db_sha.update(data)
f_out.write(data)
content_length = f.getheader('content-length')
if http_code and content_length and os.path.getsize(new_file) != content_length:
self.logger.info('Short read downloading autopkgtest results')
if http_code and local_db_sha.hexdigest() != chksum:
self.logger.info("autopkgtest.db local checksum does not match downloaded checksum!")
os.unlink(new_file)
else:
os.rename(new_file, self.database_path)