From e5a438f7d4353269bbaa63727394f45500714757 Mon Sep 17 00:00:00 2001 From: Steve Langasek Date: Wed, 14 Feb 2024 08:25:55 -0800 Subject: [PATCH] Add support in code for disabling ImplicitDependencyPolicy, and disable it --- britney.conf | 2 ++ britney.py | 8 +++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/britney.conf b/britney.conf index 80003ed..145c189 100644 --- a/britney.conf +++ b/britney.conf @@ -89,6 +89,8 @@ REMOVE_OBSOLETE = no CHECK_BUILDD = no +IMPLICIT_DEPS = no + ADT_ENABLE = yes ADT_ARCHES = amd64 i386 armhf ppc64el arm64 ADT_AMQP = amqp://test_request:password@autopkgtest-amqp.internal diff --git a/britney.py b/britney.py index 3063dd2..8d8f427 100755 --- a/britney.py +++ b/britney.py @@ -538,7 +538,13 @@ class Britney(object): self._policy_engine.add_policy(BlockPolicy(self.options, self.suite_info)) # XXX re-enable once https://bugs.launchpad.net/launchpad/+bug/1868558 is fixed # self._policy_engine.add_policy(BuiltUsingPolicy(self.options, self.suite_info)) - self._policy_engine.add_policy(ImplicitDependencyPolicy(self.options, self.suite_info)) + # This policy is objectively terrible, it reduces britney runtime + # at the cost of giving only partial information about blocking + # packages during large transitions instead of giving full detail in + # update_output that the team can work through in parallel, thus + # dragging out complicated transitions. vorlon 20240214 + if getattr(self.options, 'implicit_deps', 'yes') == 'yes': + self._policy_engine.add_policy(ImplicitDependencyPolicy(self.options, self.suite_info)) if getattr(self.options, 'check_buildd', 'no') == 'yes': self._policy_engine.add_policy(BuiltOnBuilddPolicy(self.options, self.suite_info)) self._policy_engine.add_policy(LPBlockBugPolicy(self.options, self.suite_info))