Lubuntu/britney2-ubuntu
8
0
Fork 0
mirror of https://git.launchpad.net/~ubuntu-release/britney/+git/britney2-ubuntu synced 2025-06-04 22:31:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

britney_util: Replace broken if with an assert

Browse Source 
Replace a "if" with an unconditionally false condition with a negative
assert of the "correct" condition.  The bug has been present for 2½
years with no known adverse effects.

Signed-off-by: Niels Thykier <niels@thykier.net>
This commit is contained in:
Niels Thykier 2016-04-30 19:07:33 +00:00
parent ec37bd06aa
commit e92bbf386f
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
britney_util.py
View File

@ -148,9 +148,7 @@ def undo_changes(lundo, inst_tester, sources, binaries, all_binary_packages,
inst_tester.remove_testing_binary(binary, version, arch) inst_tester.remove_testing_binary(binary, version, arch)
else: else:
binaries_t_a = binaries['testing'][arch][0] binaries_t_a = binaries['testing'][arch][0]
if p in binaries_t_a: assert binary not in binaries_t_a
rmpkgdata = binaries_t_a[p]
inst_tester.remove_testing_binary((binary, rmpkgdata.version, arch))
pkgdata = all_binary_packages[undo['binaries'][p]] pkgdata = all_binary_packages[undo['binaries'][p]]
binaries_t_a[binary] = pkgdata binaries_t_a[binary] = pkgdata
inst_tester.add_testing_binary((binary, pkgdata.version, arch)) inst_tester.add_testing_binary((binary, pkgdata.version, arch))