From ee12b76885d74d0e9734e1a20fa449b54060733f Mon Sep 17 00:00:00 2001
From: Niels Thykier <niels@thykier.net>
Date: Sun, 29 Jan 2017 12:41:40 +0000
Subject: [PATCH] tests: Add test for some invalid hints

Signed-off-by: Niels Thykier <niels@thykier.net>
---
 britney2/hints.py         |  4 +++
 tests/test_hint_parser.py | 58 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 62 insertions(+)
 create mode 100644 tests/test_hint_parser.py

diff --git a/britney2/hints.py b/britney2/hints.py
index 686412e..cbe9a68 100644
--- a/britney2/hints.py
+++ b/britney2/hints.py
@@ -25,6 +25,10 @@ class HintCollection(object):
     def __init__(self):
         self._hints = []
 
+    @property
+    def is_empty(self):
+        return not self._hints
+
     def __getitem__(self, type=None):
         return self.search(type)
 
diff --git a/tests/test_hint_parser.py b/tests/test_hint_parser.py
new file mode 100644
index 0000000..043c044
--- /dev/null
+++ b/tests/test_hint_parser.py
@@ -0,0 +1,58 @@
+import unittest
+
+from britney2.hints import HintParser
+
+from . import MockObject, HINTS_ALL, TEST_HINTER
+
+
+def new_hint_paser(logger=None):
+    if logger is None:
+        def empty_logger(x, type='I'):
+            pass
+        logger = empty_logger
+    fake_britney = MockObject(log=logger)
+    hint_parser = HintParser(fake_britney)
+    return hint_parser
+
+
+def parse_should_not_call_this_function(*args, **kwargs):
+    raise AssertionError("Should not be called")
+
+
+class HintParsing(unittest.TestCase):
+
+    def test_parse_invalid_hints(self):
+        hint_log = []
+        hint_parser = new_hint_paser(lambda x, type='I': hint_log.append(x))
+
+        hint_parser.register_hint_type('min-10-arg', parse_should_not_call_this_function, min_args=10)
+        hint_parser.register_hint_type('simple-hint', parse_should_not_call_this_function)
+
+        tests = [
+            {
+                'hint_text': 'min-10-arg foo bar',
+                'permissions': HINTS_ALL,
+                'error_message_contains': 'Needs at least 10 argument(s), got'
+            },
+            {
+                'hint_text': 'undefined-hint with some arguments',
+                'permissions': HINTS_ALL,
+                'error_message_contains': 'Unknown hint found in'
+            },
+            {
+                'hint_text': 'simple-hint foo/1.0',
+                'permissions': ['not-this-hint'],
+                'error_message_contains': 'not a part of the permitted hints for'
+            },
+        ]
+
+        for test in tests:
+            hint_parser.parse_hints(TEST_HINTER, test['permissions'], 'test-parse-hint', [test['hint_text']])
+            assert len(hint_log) == 1
+            assert test['error_message_contains'] in hint_log[0]
+            assert hint_parser.hints.is_empty
+            hint_log.clear()
+
+
+if __name__ == '__main__':
+    unittest.main()