97abb6f467
ExcuseFinder: Reduce the number of migration items created
...
With this change, we reduce the number of migration items creted only
to be discarded because the item is not relevant/actionable.
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
78d120114f
ExcuseFinder: Merge two loops
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
9a0a99abc9
ExcuseFinder: Have _should_* work on migration items
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
d9f9c6d4a9
Let ExcuseFinder create migration items
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
6dde43a339
Create an ExcuseFinder class for computing relevant excuses
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
59633a92b5
Clone all_buildarchs before mutating it
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
2c9e0b9b97
do_all: Prune cruft after non-recursive hints (e.g. "easy")
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
c30ecbb7e8
Skip cruft on source migration / removal items
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
73791e48d0
Rename migrate_item{,s}_to_target_suite
...
It accepts multiple items, so using a singular "item" seems like a
misfeature.
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
5d408fa800
Remove new cruft items in iter_packages
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
32ebe9d4e0
Ensure get_auto_hinter_hints does not choke on cruft items
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
16f823dd91
autopkgtest: in Debian we want linux to be treated as any other
6 years ago
1ca76486b5
Replace libreoffice with doxygen as the libgcc smoke test for gcc.
...
Bug-Ubuntu: https://bugs.launchpad.net/bugs/1793260
Original patches by Steve Langasek
6 years ago
69d42ffb36
solver: improve apply_order to simplify more code
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
b306700376
solver: Extract a function from _comute_group_order_adds
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
259fecf6cf
solver: Rename a variable to avoid confusion
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
cdcfe85bfa
solver: Replace dict with a proper object
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
93f101bee2
solver: Extract some common code into a function
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
2ed6161b49
solver: Refactor out a function to avoid duplicated code
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
af20634b12
solver: Merge some loops to reduce nesting level
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
b61e1086bd
solver: Invert an if-statement to reduce max indentation level
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
68407c53c0
Remove an unnecessary if-statement
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
9971714e27
solver: Merge two loops by using chain
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
16dc303190
solver: Reduce two small loops into a comprehension
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
d3e06fc45f
solver: Split _compute_group_order into three methods
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
c65b377c5d
solver: Split solve_groups into 3 smaller methods
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
4eb038ab6d
autopkgtest: Move field creation into __init__
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
1ecb07ac2d
autopkgtest: bug fix in baseline cache
6 years ago
075d4d823b
autopkgtest: fix copy() in save_state
6 years ago
c6c5c45287
autopkgtest: tiny change for easier understanding
6 years ago
d038e7bbe6
autopkgtest: simplify bin_triggers logic/naming
6 years ago
caf83b9357
Fix the remaining two style issues in britney2/__init__.py
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
e0b46e5196
Make the source pkg consistency checks a TargetSuite method
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
b200c15062
Add a missing "no cover"
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
427328821e
Remove redundant variables
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
b0835fa4a1
Fix pycodestyle warnings
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
66648c1a03
Add BuiltUsingPolicy
...
Signed-off-by: Ivo De Decker <ivodd@debian.org>
6 years ago
4fcb90b775
Read Built-Using info for binary packages
...
Signed-off-by: Ivo De Decker <ivodd@debian.org>
6 years ago
35ae8848b4
Fix apply_src_policies when policy is applied on multiple archs
...
Move the logic of apply_src_policy and apply_srcarch_policy into PolicyEngine.
This fixes an issue with the excuses.yaml output introduced in commit
15e5228669: only the last verdict was added to the excuse info for that
policy.
Signed-off-by: Ivo De Decker <ivodd@debian.org>
6 years ago
bb699f7416
Make britney2/utils.py PEP-8 clean
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
5a38e00996
Fix pep8 issues in check_target_suite_source_pkg_consistency
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
c9d523da93
Remove trailing whitespace
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
cd08deb943
Fix build-dep check for source with only arch: all binaries
...
When a source has only arch: all binaries, the Build-Depends had no relevant
architectures, so the check was skipped. Instead check it on any architecture,
just like Build-Depends-Indep.
Signed-off-by: Ivo De Decker <ivodd@debian.org>
6 years ago
15e5228669
Add src_policy option to policies.
...
The src_policy defines wether, for source items, the source policy should be
run (RUN_SRC, the default), the arch policy should be run on every arch
(RUN_ON_EVERY_ARCH_ONLY), or both (RUN_SRC_AND_EVERY_ARCH).
Signed-off-by: Ivo De Decker <ivodd@debian.org>
6 years ago
82fa58df20
Extract a compute_item_name method
...
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
97ed917db4
Sort some data for deterministic output in excuses
...
Signed-off-by: Ivo De Decker <ivodd@debian.org>
6 years ago
f928c7ed3d
Make SourcePackage.binaries a set
...
The recent code changes made use remove from the "binaries" field in
SourcePackages. Lists are not particularly optimized for this kind
of removal and we have a few source packages with a lot of binary
packages (e.g. libreoffice, gcc-X-cross{,-ports}) that might trip
poor performance.
Signed-off-by: Niels Thykier <niels@thykier.net>
6 years ago
37a173af67
Always create a new SourcePackage
...
When an item is migrated to the target suite, always create a new
SourcePackage object with a separate binaries list (independent from the list
in the source suite). That list is updated for every binary that is added,
updated or removed. This should ensure consistent source package information
in the target suite.
The undo code doesn't need to be updated for this, because the old
SourcePackage object is put back on undo, with the old binary list.
Signed-off-by: Ivo De Decker <ivodd@debian.org>
6 years ago
7bba77726b
Always define source_t in apply_item_to_target_suite
...
Signed-off-by: Ivo De Decker <ivodd@debian.org>
6 years ago
69c94caa01
Add source_name return value to compute_groups
...
When the item is a single binary cruft removal, the source name is different
from the package. compute_groups has this info anyway, so just pass it on as a
returm value.
Signed-off-by: Ivo De Decker <ivodd@debian.org>
6 years ago
Niels Thykier
Paul Gevers
Ivo De Decker