britney2-ubuntu

britney2-ubuntu fork which runs on ci.lubuntu.me

Go to file

Niels Thykier 4ced8a3d41 britney.py: Fix crash with arch:all packages being shadowed There was an implicit assumption in Britney that was violated recently (presumbly in `12d9ae8`). This assumption is that a source package will reference the latest version of an arch:all package; even if that version is not built by that source (version). Image the following packages: * p-all/1 and p-all/2 are arch:all packages. - p-all/1 is generally superseded by p-all/2 except it has not been removed yet (regardless of why that happens). * src-a/2 builds p-all/2. When Britney loads the packages (assuming packages are sorted[1]): * p-all/1 is read and associated with src-a/2 (despite not being built from that source) * p-all/2 is read afterwards. It would replace p-all/1 and be assoicated with src-a/2 as well. - Prior to `12d9ae8`, the assoication would be "pkg, arch" and therefore the same. - In 12d9ae8a and after, the association would include version and both would be associated at the same time. * Since p-all/1 is discarded, it is never added to the installability tester (nor the solver). It then promptly throws an exception when asked to deal with a package it believe does not exist. - This can trivially be solved by removing the association between p-all/1 and src-a/2 when p-all/2 is read. So far so good. Unfortunately, this adds another another problem! When Britney migrates a binNMU, she currently removes all binary packages on that architecture - including the arch:all packages. This works out in the end because the arch:all packages be re-added since they associated with the source package. At first glance, this appears to be a non-issue until you add hijacking to the mix. This is exactly the case behind #709460. However, now we end up in a situation where the arch:all package is removed during binNMU and not re-added (because the arch:all package is not associated with that source any more). This commit fixes all of the above by: 1) Correctly disassociating superseded arch:all packages from their source packages 2) Falsely associating the "new" arch:all package to the source that provided the superseded arch:all package (to avoid issues with binNMUs and hijacked packages). - This should probably be undone at some point when Britney does not need this "hack" any more. This fix is currently relying on the packages being sorted. But so did the fix for #709460 (see [1] again). It might be prudent to fix that as well (or at least reject the packages file rather than produce "random" results). [1] Which is another assumption we have been relying and that is currently satisfied. Signed-off-by: Niels Thykier <niels@thykier.net>		9 years ago
doc	Fixed a typo in the doxygen.conf file	13 years ago
installability	Remove unused named parameter	9 years ago
.gitignore	Add a .gitignore file.	17 years ago
BUGS	At this point, we could schedule a periodic diff between the original excuses and the new ones; everything seems to be the same (excluding the usual bugs in the	17 years ago
INSTALL	INSTALL: Update dependency for Python 3	9 years ago
LICENSE	Initial import, excuses generation almost working.	19 years ago
README	Initial import, excuses generation almost working.	19 years ago
TODO	TODO: fix typoes; thanks, Julien Cristau	13 years ago
britney.conf	Give me force-hint permissions	9 years ago
britney.py	britney.py: Fix crash with arch:all packages being shadowed	9 years ago
britney_nobreakall.conf	Give me force permissions	9 years ago
britney_util.py	Remove two redundant ifs duplicating an earlier if	9 years ago
completer.py	Remove unused assignments/parameters	10 years ago
consts.py	Drop now unused register_reverses and RDEPENDS	9 years ago
excuse.py	sort reason in excuses for easy diffing	9 years ago
hints.py	Move some of the hint parsing into hints.py	9 years ago
migrationitem.py	Use python3-style super()	10 years ago

README

README for britney v2.0
=======================

Please write here some useful stuff.