You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
23 lines
1023 B
23 lines
1023 B
6 years ago
|
Description: [partition] Drop some re-parenting trickery
|
||
|
|
Can't re-parent across threads easily. If device is made by
|
||
|
|
immutableDeviceCopy(), then it's still owned by the PartitionCoreModule;
|
||
|
|
giving it away to the widget is not a good idea.
|
||
|
|
Author: Adriaan de Groot <groot@kde.org>
|
||
|
|
Origin: upstream
|
||
|
|
Applied-Upstream: commit:2092ec3c9a0a37553fd061f423df9d29fe55ab80
|
||
|
|
Last-Update: 2019-04-11
|
||
|
|
--- a/src/modules/partition/gui/ChoicePage.cpp
|
||
|
|
+++ b/src/modules/partition/gui/ChoicePage.cpp
|
||
|
|
@@ -882,11 +882,6 @@ ChoicePage::updateDeviceStatePreview()
|
||
|
|
PartitionModel* model = new PartitionModel( m_beforePartitionBarsView );
|
||
|
|
model->init( deviceBefore, m_core->osproberEntries() );
|
||
|
|
|
||
|
|
- // The QObject parents tree is meaningful for memory management here,
|
||
|
|
- // see qDeleteAll above.
|
||
|
|
- deviceBefore->setParent( model ); // Can't reparent across threads
|
||
|
|
- model->setParent( m_beforePartitionBarsView );
|
||
|
|
-
|
||
|
|
m_beforePartitionBarsView->setModel( model );
|
||
|
|
m_beforePartitionLabelsView->setModel( model );
|
||
|
|
|