Actually enforce non-empty passwords

2025-04-05 07:11:10 +00:00 · 2024-03-10 18:20:39 -05:00 · 2024-03-10 18:20:39 -05:00 · 3cf89c92ab
commit 3cf89c92ab
parent 5356eeab97
7 changed files with 17 additions and 18 deletions
--- a/debian/changelog
+++ b/debian/changelog
@ -6,6 +6,11 @@ calamares-settings-ubuntu (1:24.04.17) noble; urgency=medium
  [ Aaron Rainbolt ]
  * Wipe Ubuntu Studio's configuration while preserving branding, Studio now
    uses ubuntu-desktop-provision.
+  * Migrate from users.conf password setting "nonEmpty: true" to
+    "minLength: 1" to enforce non-empty passwords.
+    - This is not a new feature, we had non-empty passwords being enforced in
+      the past and didn't intentionally undo this, but Calamares dropped the
+      "nonEmpty: true" setting we were using.

 -- Aaron Rainbolt <arraybolt3@ubuntu.com>  Sun, 10 Mar 2024 18:10:03 -0500

--- a/kubuntu/modules/users.conf
+++ b/kubuntu/modules/users.conf
@ -13,9 +13,8 @@ defaultGroups:
      system: true
    - sudo
 passwordRequirements:
-    nonempty: true
-    minLength: 0
-    maxLength: 0
+    minLength: 1
+    maxLength: -1
 # Explicitly set the shell instead of deferring to Calamares. We have a platform
 # expectation derived from Ubuntu here.
 user:
--- a/kubuntu/modules/users.conf.oem
+++ b/kubuntu/modules/users.conf.oem
@ -13,9 +13,8 @@ defaultGroups:
      system: true
    - sudo
 passwordRequirements:
-    nonempty: true
-    minLength: 0
-    maxLength: 0
+    minLength: 1
+    maxLength: -1
 # Explicitly set the shell instead of deferring to Calamares. We have a platform
 # expectation derived from Ubuntu here.
 user:
--- a/kubuntu/oem/modules/users.conf
+++ b/kubuntu/oem/modules/users.conf
@ -13,9 +13,8 @@ defaultGroups:
      system: true
    - sudo
 passwordRequirements:
-    nonempty: true
-    minLength: 0
-    maxLength: 0
+    minLength: 1
+    maxLength: -1
 # Explicitly set the shell instead of deferring to Calamares. We have a platform
 # expectation derived from Ubuntu here.
 user:
--- a/lubuntu/modules/users.conf
+++ b/lubuntu/modules/users.conf
@ -13,9 +13,8 @@ defaultGroups:
      system: true
    - sudo
 passwordRequirements:
-    nonempty: true
-    minLength: 0
-    maxLength: 0
+    minLength: 1
+    maxLength: -1
 # Explicitly set the shell instead of deferring to Calamares. We have a platform
 # expectation derived from Ubuntu here.
 user:
--- a/lubuntu/modules/users.conf.oem
+++ b/lubuntu/modules/users.conf.oem
@ -13,9 +13,8 @@ defaultGroups:
      system: true
    - sudo
 passwordRequirements:
-    nonempty: true
-    minLength: 0
-    maxLength: 0
+    minLength: 1
+    maxLength: -1
 # Explicitly set the shell instead of deferring to Calamares. We have a platform
 # expectation derived from Ubuntu here.
 user:
--- a/lubuntu/oem/modules/users.conf
+++ b/lubuntu/oem/modules/users.conf
@ -13,9 +13,8 @@ defaultGroups:
      system: true
    - sudo
 passwordRequirements:
-    nonempty: true
-    minLength: 0
-    maxLength: 0
+    minLength: 1
+    maxLength: -1
 # Explicitly set the shell instead of deferring to Calamares. We have a platform
 # expectation derived from Ubuntu here.
 user: