Remove all password checking.

Summary:
We were using password checking in Calamares, especially as supported by libpwquality, but have received overwhelming community feedback against this. Therefore, we remove any checking by libpwquality, including defaults that aren't explicit, like the dictionary check. Sadly, it seems that setting enforcing=0 to simply print a warning does not work. IIt's possible that this is a bug, but not worth chasing at this point. The only thing unsupported is a blank password, but that's something that's [not clear](https://github.com/calamares/calamares/issues/790#issuecomment-330455711) is supported.

The good news is that the [string](743c19d8dd/src/modules/users/page_usersetup.ui (L440)) suggesting a good password is still there. If there's anywhere to be additional improments, it's there.

Test Plan: Run Calamares and enter a variety of lame passwords (e.g. space, the number one, the letter a, the word cat, etc.) twice. If the "next" button is not greyed out, it succeeds.

Reviewers: tsimonq2

Reviewed By: tsimonq2

Differential Revision: https://phab.lubuntu.me/D12
This commit is contained in:
Walter Lapchynski 2018-08-26 13:23:12 -05:00 committed by Simon Quigley
parent 4f328dc3d7
commit fcc2036633
2 changed files with 8 additions and 5 deletions

6
debian/changelog vendored
View File

@ -1,3 +1,9 @@
calamares-settings-ubuntu (21) cosmic; urgency=medium
* Lubuntu: remove all password checking.
-- Walter Lapchynski <wxl@ubuntu.com> Sat, 25 Aug 2018 17:43:33 -0700
calamares-settings-ubuntu (20) cosmic; urgency=medium
* Lubuntu: add executable to defaultDesktopEnvironment in displaymanager.

View File

@ -11,11 +11,8 @@ defaultGroups:
- sambashare
- sudo
passwordRequirements:
minLength: 5
maxLength: 200
libpwquality:
- minlen=0
- minclass=0
minLength: 0
maxLength: 0
# Explicitly set the shell instead of deferring to Calamares. We have a platform
# expectation derived from Ubuntu here.
userShell: /bin/bash