Summary: When opening an URL, an error may be raised and the wrong, not defined variable was logged.
Test Plan: Create an HTTPError or an URLError (socket.timeout), when opening "https://ipapi.co/json"
Reviewers: wxl, tsimonq2, kc2bez
Reviewed By: wxl, kc2bez
Differential Revision: https://phab.lubuntu.me/D42
Summary:
This resolves T107
Refactor automirror
Add donate button url and geoip to welcome
Adjust locale.conf geoip format
Set default filesystem type and no user swap choices
Add defaults to settings to eliminate warnings
Add efi mount options to fstab.conf
Set restart mode in finished.conf to new style
Set bootloader entry name to Ubuntu and slideshowAPI to 1
Test Plan:
Test Calamares installation for proper location detection.
Test Calamares installation for proper efi mount.
Test Calamares installation for proper bootloader entry.
Reviewers: tsimonq2, wxl, apt-ghetto
Reviewed By: tsimonq2, wxl
Subscribers: apt-ghetto
Maniphest Tasks: T107
Differential Revision: https://phab.lubuntu.me/D33
Summary:
* Updated automirror.conf
* Removed useless configs
* Added URL for the country code
* Refactored main.py
* Added dictionary with the subdomains of some countries
* Simplified logic
* Removed premature optimizations
* Renamed variables and methods
Test Plan: Compare this version with the previous version. The behaviour is expected to be the same.
Reviewers: tsimonq2, wxl
Differential Revision: https://phab.lubuntu.me/D49
Summary: Adding one line fix to only import socket
Test Plan: Will test in isolated instance of main.py to ensure function
Reviewers: wxl, tsimonq2
Reviewed By: tsimonq2
Differential Revision: https://phab.lubuntu.me/D47
Summary: Updated automirror for urllib.request
Test Plan:
Verify basic function in US, but then also have non-US users test for functionality, especially paying attention to time.
More specifically, this patch should be able to be applied directly to /usr/lib/(i138-linux-gnu|x86_64-linux-gnu)/calamares/modules/automirror/main.py in a live system, then run the installer and see what happens.
Reviewers: tsimonq2, wxl
Reviewed By: tsimonq2
Differential Revision: https://phab.lubuntu.me/D23
Aaron Rainbolt
Erich Eickmeyer
apt-ghetto
Simon Quigley
apt-ghetto
Samuel Banya