Lubuntu/ci-tools
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use functions directly instead of grabbing many locks at once

Browse Source
This commit is contained in:
Simon Quigley 2025-01-26 22:35:57 -06:00
parent 1ecec033f1
commit 9a35473d37
1 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
cpp/ci_logic.cpp
View File

@ -577,24 +577,18 @@ std::vector<std::shared_ptr<PackageConf>> CiLogic::get_config(const std::string
: (a->package->name > b->package->name); : (a->package->name > b->package->name);
} }
} else if (sort_by == "build_status") { } else if (sort_by == "build_status") {
int a_successful_task_count = a->successful_task_count(); if (a->successful_task_count() != b->successful_task_count()) {
int b_successful_task_count = b->successful_task_count();
int a_successful_or_pending_task_count = a->successful_or_pending_task_count();
int b_successful_or_pending_task_count = b->successful_or_pending_task_count();
int a_successful_or_queued_task_count = a->successful_or_queued_task_count();
int b_successful_or_queued_task_count = b->successful_or_queued_task_count();
if (a_successful_task_count != b_successful_task_count) {
return (order == "asc") return (order == "asc")
? (a_successful_task_count < b_successful_task_count) ? (a->successful_task_count() < b->successful_task_count())
: (a_successful_task_count > b_successful_task_count); : (a->successful_task_count() > b->successful_task_count());
} else if (a_successful_or_pending_task_count != b_successful_or_pending_task_count) { } else if (a->successful_or_pending_task_count() != b->successful_or_pending_task_count()) {
return (order == "asc") return (order == "asc")
? (a_successful_or_pending_task_count < b_successful_or_pending_task_count) ? (a->successful_or_pending_task_count() < b->successful_or_pending_task_count())
: (a_successful_or_pending_task_count > b_successful_or_pending_task_count); : (a->successful_or_pending_task_count() > b->successful_or_pending_task_count());
} else if (a_successful_or_queued_task_count != b_successful_or_queued_task_count) { } else if (a->successful_or_queued_task_count() != b->successful_or_queued_task_count()) {
return (order == "asc") return (order == "asc")
? (a_successful_or_queued_task_count < b_successful_or_queued_task_count) ? (a->successful_or_queued_task_count() < b->successful_or_queued_task_count())
: (a_successful_or_queued_task_count > b_successful_or_queued_task_count); : (a->successful_or_queued_task_count() > b->successful_or_queued_task_count());
} else { } else {
return (order == "asc") return (order == "asc")
? (a->total_task_count() < b->total_task_count()) ? (a->total_task_count() < b->total_task_count())