Lubuntu/ci-tools
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Less calls to functions with locks

Browse Source
This commit is contained in:
Simon Quigley 2025-01-28 12:22:03 -06:00
parent b82181d3f3
commit 9c53398fc9
1 changed files with 32 additions and 16 deletions

48
cpp/ci_logic.cpp

@ -581,23 +581,39 @@ std::vector<std::shared_ptr<PackageConf>> CiLogic::get_config(const std::string
: (a->package->name > b->package->name);
}
} else if (sort_by == "build_status") {
if (a->successful_task_count() != b->successful_task_count()) {
return (order == "asc")
? (a->successful_task_count() < b->successful_task_count())
: (a->successful_task_count() > b->successful_task_count());
} else if (a->successful_or_pending_task_count() != b->successful_or_pending_task_count()) {
return (order == "asc")
? (a->successful_or_pending_task_count() < b->successful_or_pending_task_count())
: (a->successful_or_pending_task_count() > b->successful_or_pending_task_count());
} else if (a->successful_or_queued_task_count() != b->successful_or_queued_task_count()) {
return (order == "asc")
? (a->successful_or_queued_task_count() < b->successful_or_queued_task_count())
: (a->successful_or_queued_task_count() > b->successful_or_queued_task_count());
} else {
return (order == "asc")
? (a->total_task_count() < b->total_task_count())
: (a->total_task_count() > b->total_task_count());
{
int a_successful_task_count = a->successful_task_count();
int b_successful_task_count = b->successful_task_count();
if (a_successful_task_count != b_successful_task_count) {
return (order == "asc")
? (a_successful_task_count < b_successful_task_count)
: (a_successful_task_count > b_successful_task_count);
}
}
{
int a_successful_or_pending_task_count = a->successful_or_pending_task_count();
int b_successful_or_pending_task_count = b->successful_or_pending_task_count();
if (a_successful_or_pending_task_count != b_successful_or_pending_task_count) {
return (order == "asc")
? (a_successful_or_pending_task_count < b_successful_or_pending_task_count)
: (a_successful_or_pending_task_count > b_successful_or_pending_task_count);
}
}
{
int a_successful_or_queued_task_count = a->successful_or_queued_task_count();
int b_successful_or_queued_task_count = b->successful_or_queued_task_count();
if (a_successful_or_queued_task_count != b_successful_or_queued_task_count) {
return (order == "asc")
? (a_successful_or_queued_task_count < b_successful_or_queued_task_count)
: (a_successful_or_queued_task_count > b_successful_or_queued_task_count);
}
}
return (order == "asc")
? (a->total_task_count() < b->total_task_count())
: (a->total_task_count() > b->total_task_count());
}
// if invalid sort_by
return false;