Add retry support for failed LP requests

main
Simon Quigley 6 days ago
parent 7879ec07be
commit 48518fc076

@ -257,8 +257,12 @@ std::optional<std::string> launchpad::api_get(const std::string& endpoint, const
curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, WriteCallback);
curl_easy_setopt(curl, CURLOPT_WRITEDATA, &readBuffer);
CURLcode res = curl_easy_perform(curl);
bool tries = 0;
long http_code = 0;
while (tries < 5) {
tries++;
CURLcode res = curl_easy_perform(curl);
if (res != CURLE_OK) {
std::cerr << "CURL GET error: " << curl_easy_strerror(res) << std::endl;
}
@ -268,17 +272,20 @@ std::optional<std::string> launchpad::api_get(const std::string& endpoint, const
curl_easy_cleanup(curl);
if (res != CURLE_OK) {
return std::nullopt;
continue;
}
if (http_code >= 400) {
std::cerr << "HTTP GET request to " << url << " failed with code: " << http_code << "\nResponse: " << readBuffer << std::endl;
return std::nullopt;
continue;
}
return readBuffer;
}
std::cerr << "HTTP GET request to " << url << " failed with code: " << http_code << "\nResponse: " << readBuffer << std::endl;
return std::nullopt;
}
std::optional<std::string> launchpad::api_post(
const std::string& endpoint,
const std::map<std::string, std::string>& params,
@ -327,8 +334,12 @@ std::optional<std::string> launchpad::api_post(
curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, WriteCallback);
curl_easy_setopt(curl, CURLOPT_WRITEDATA, &readBuffer);
CURLcode res = curl_easy_perform(curl);
bool tries = 0;
long http_code = 0;
while (tries < 5) {
tries++;
CURLcode res = curl_easy_perform(curl);
if (res != CURLE_OK) {
std::cerr << "CURL POST error: " << curl_easy_strerror(res) << std::endl;
}
@ -338,16 +349,18 @@ std::optional<std::string> launchpad::api_post(
curl_easy_cleanup(curl);
if (res != CURLE_OK) {
return std::nullopt;
continue;
}
if (http_code >= 400) {
std::cerr << "HTTP POST request to " << url << " failed with code: " << http_code << "\nResponse: " << readBuffer << std::endl;
return std::nullopt;
continue;
}
return readBuffer;
}
std::cerr << "HTTP POST request to " << url << " failed with code: " << http_code << "\nResponse: " << readBuffer << std::endl;
return std::nullopt;
}
std::optional<std::string> launchpad::api_patch(const std::string& endpoint, const nlohmann::json& data) {
std::string url = build_full_url(endpoint) + "?ws.op=edit";

Loading…
Cancel
Save