From e5f211ecf7f8024ffcb71ea16bcd686601765d3e Mon Sep 17 00:00:00 2001
From: Simon Quigley <simon@tsimonq2.net>
Date: Mon, 16 Dec 2024 17:50:43 -0600
Subject: [PATCH] Use string directly

---
 src/archive.cpp | 19 ++++++++++---------
 src/archive.h   | 18 +++++++++---------
 2 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/src/archive.cpp b/src/archive.cpp
index 61a770a..a5f76a7 100644
--- a/src/archive.cpp
+++ b/src/archive.cpp
@@ -155,15 +155,15 @@ std::generator<archive_permission> archive::getAllPermissions() const {
 }
 
 std::generator<source_package_publishing_history> archive::getPublishedSources(
-    const std::string& component_name,
-    const std::string& created_since_date,
+    const std::string component_name,
+    const std::string created_since_date,
     std::optional<distro_series> ds,
     const bool exact_match,
     const bool order_by_date,
-    const std::string& pocket,
-    const std::string& source_name,
-    const std::string& status,
-    const std::string& version
+    const std::string pocket,
+    const std::string source_name,
+    const std::string status,
+    const std::string version
 ) const {
     std::map<std::string, std::string> params = {
         {"exact_match", exact_match ? "true" : ""},
@@ -245,11 +245,12 @@ std::optional<nlohmann::json> archive::getBuildCounters(bool include_needsbuild)
     return nlohmann::json::parse(response.value());
 }
 
-std::generator<build> archive::getBuildRecords(const std::string& build_state,
-                                               const std::string& pocket,
-                                               const std::string& source_name) const {
+std::generator<build> archive::getBuildRecords(const std::string build_state,
+                                               const std::string pocket,
+                                               const std::string source_name) const {
     std::map<std::string,std::string> params;
     params["ws.op"] = "getBuildRecords";
+    std::cout << "!!!!!!!! " << build_state << std::endl;
     if(!build_state.empty()) params["build_state"] = build_state;
     if(!pocket.empty()) params["pocket"] = pocket;
     if(!source_name.empty()) params["source_name"] = source_name;
diff --git a/src/archive.h b/src/archive.h
index 5f6fdbc..fa4d356 100644
--- a/src/archive.h
+++ b/src/archive.h
@@ -79,15 +79,15 @@ public:
     std::string web_link;
 
     std::generator<source_package_publishing_history> getPublishedSources(
-        const std::string& component_name = "",
-        const std::string& created_since_date = "",
+        const std::string component_name = "",
+        const std::string created_since_date = "",
         std::optional<distro_series> ds = std::nullopt,
         const bool exact_match = false,
         const bool order_by_date = false,
-        const std::string& pocket = "",
-        const std::string& source_name = "",
-        const std::string& status = "",
-        const std::string& version = ""
+        const std::string pocket = "",
+        const std::string source_name = "",
+        const std::string status = "",
+        const std::string version = ""
     ) const;
     std::generator<archive_permission> getAllPermissions() const;
 
@@ -99,9 +99,9 @@ public:
                                               bool strict_component = false) const;
     std::optional<archive_dependency> getArchiveDependency(const std::string& dependency_link) const;
     std::optional<nlohmann::json> getBuildCounters(bool include_needsbuild = false) const;
-    std::generator<build> getBuildRecords(const std::string& build_state = "",
-                                          const std::string& pocket = "",
-                                          const std::string& source_name = "") const;
+    std::generator<build> getBuildRecords(const std::string build_state = "",
+                                          const std::string pocket = "",
+                                          const std::string source_name = "") const;
     std::optional<nlohmann::json> getBuildSummariesForSourceIds(const std::vector<std::string>& source_ids) const;
     std::generator<archive_permission> getComponentsForQueueAdmin(const std::string& person_link) const;
     std::optional<nlohmann::json> getNamedAuthToken(const std::string& name) const;