Lubuntu/livecd-rootfs
3
0
Fork 0
mirror of https://git.launchpad.net/livecd-rootfs synced 2025-03-31 04:41:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Treat it as a fatal error if we are asked to install a snap that would pull in the core snap. Ubuntu 20.04 and Ubuntu 22.04 official images should never require snaps that depend on an Ubuntu 16.04 runtime, this indicates a misconfiguration that will bloat the install.

Browse Source
This commit is contained in:
Steve Langasek 2022-01-11 16:32:51 -08:00
parent bcfad43fd4
commit 245f7772bd
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
debian/changelog vendored
View File

@ -2,6 +2,10 @@ livecd-rootfs (2.750) UNRELEASED; urgency=medium
* Do not look for a base snap on snaps of type base, because recursive * Do not look for a base snap on snaps of type base, because recursive
dependencies are not allowed for snaps. LP: #1957123. dependencies are not allowed for snaps. LP: #1957123.
* Treat it as a fatal error if we are asked to install a snap that would
pull in the core snap. Ubuntu 20.04 and Ubuntu 22.04 official images
should never require snaps that depend on an Ubuntu 16.04 runtime, this
indicates a misconfiguration that will bloat the install.
-- Steve Langasek <steve.langasek@ubuntu.com> Tue, 11 Jan 2022 15:38:05 -0800 -- Steve Langasek <steve.langasek@ubuntu.com> Tue, 11 Jan 2022 15:38:05 -0800

8
live-build/functions
View File

@ -597,8 +597,12 @@ _snap_preseed() {
if [ "$snap_type" != base ]; then if [ "$snap_type" != base ]; then
local core_snap=$(echo "$snap_info" | awk '/^base:/ {print $2}') local core_snap=$(echo "$snap_info" | awk '/^base:/ {print $2}')
# If snap info does not list a base use 'core' # If snap info does not list a base the default is 'core'
core_snap=${core_snap:-core} # which is now an error to use.
if [ -z "$core_snap" ]; then
echo "Legacy snap with no base declaration found, refusing to install 'core' snap"
exit 1
fi
_snap_preseed $CHROOT_ROOT $core_snap stable _snap_preseed $CHROOT_ROOT $core_snap stable
fi fi