diff --git a/debian/changelog b/debian/changelog index bd78a3fa..4564abf5 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +livecd-rootfs (2.742.1) impish; urgency=medium + + [ Thomas Bechtold ] + * magic-proxy: fix exception handling for URLError LP: #1946520 + + -- Brian Murray Thu, 18 Nov 2021 15:17:05 -0800 + livecd-rootfs (2.742) impish; urgency=medium [ Brian Murray ] diff --git a/magic-proxy b/magic-proxy index 10f19c47..af765c32 100755 --- a/magic-proxy +++ b/magic-proxy @@ -883,8 +883,10 @@ class ProxyingHTTPRequestHandler(http.server.BaseHTTPRequestHandler): self.__send_response(e) except urllib.error.URLError as e: self.log_message( - "urlopen() failed for {} with {}".format(uri, e.reason)) - self.send_error(501, e.reason) + "urlopen() failed for {} with {}".format(uri, str(e.reason))) + # URLError.reason can either be a string or another Exception + # So do convert it to a string before sending the error (LP: #1946520) + self.send_error(501, str(e.reason)) def __get_host_path(self):