diff --git a/debian/changelog b/debian/changelog index d0475190..3dfbc626 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +livecd-rootfs (2.578.6) UNRELEASED; urgency=medium + + [ Tobias Koch ] + * Do proper error checking when calling snap-tool info to determine + the base of a snap. (LP: #1828500) + + -- Tobias Koch Tue, 16 Jul 2019 11:27:10 +0200 + livecd-rootfs (2.578.5) disco; urgency=medium [ Balint Reczey ] diff --git a/live-build/functions b/live-build/functions index 72fdb056..d979c9b0 100644 --- a/live-build/functions +++ b/live-build/functions @@ -483,12 +483,20 @@ _snap_preseed() { ;; *) # Determine if and what core snap is needed - local core_snap=$(/usr/share/livecd-rootfs/snap-tool info \ + local snap_info + + snap_info=$(/usr/share/livecd-rootfs/snap-tool info \ --cohort-key="${COHORT_KEY:-}" \ - --channel="$CHANNEL" "$SNAP_NAME" | \ - grep '^base:' | awk '{print $2}' + --channel="$CHANNEL" "${SNAP_NAME}" \ ) + if [ $? -ne 0 ]; then + echo "Failed to retrieve base of $SNAP_NAME!" + exit 1 + fi + + local core_snap=$(echo "$snap_info" | grep '^base:' | awk '{print $2}') + # If $core_snap is not the empty string then SNAP itself is not a core # snap and we must additionally seed the core snap. if [ -n "$core_snap" ]; then