Add support for a config file.

modules/jenkins.py

@@ -37,16 +37,21 @@ class JenkinsModule:
 
         This uses the API_SITE, API_USER, and API_KEY env vars.
         """
-        # Load the API values from the environment variables
+        # Load the config, so we can store secrets outside of env vars
-        api_site = getenv("API_SITE")
+        config = load_config()
-        api_user = getenv("API_USER")
+        in_conf = "jenkins" in config
-        api_key = getenv("API_KEY")
+
-        for envvar in [api_site, api_user, api_key]:
+        # Load the needed secrets either from the config file if it exists
+        # or the env var if it's defined (which takes precedence)
+        site = getenv("API_SITE") or (in_conf and config["jenkins"]["site"])
+        user = getenv("API_USER") or (in_conf and config["jenkins"]["user"])
+        key = getenv("API_KEY") or (in_conf and config["jenkins"]["key"])
+        for envvar in [site, user, key]:
             if not envvar:
                 raise ValueError("API_SITE, API_USER, and API_KEY must be",
                                  "defined")
         # Authenticate to the server
-        server = Jenkins(api_site, username=api_user, password=api_key)
+        server = Jenkins(site, username=user, password=key)
 
         return server
 

modules/utilities.py

@@ -15,8 +15,9 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
+import configparser
+import os
 from jinja2 import Template
-from os import path
 
 
 def jinja2_template(src, dest, **kwargs):
@@ -41,3 +42,17 @@ def jinja2_template(src, dest, **kwargs):
         f.write(template)
 
     return True
+
+def load_config(path="~/.config/lubuntumetrics"):
+    """Load config from ~/.config/lubuntumetrics or given path"""
+
+    # If it contains ~, ensure that's expanded
+    if "~" in path:
+        path = os.path.expanduser(path)
+
+    # Read from the config file
+    config = configparser.ConfigParser()
+    config.read(path)
+
+    # Return the config as a dict
+    return config