From 21784052ba76c390bde4b105e0a762333400cfc4 Mon Sep 17 00:00:00 2001 From: Benjamin Drung Date: Tue, 31 Jan 2023 17:39:12 +0100 Subject: [PATCH] test: Fix deprecated return value for test case ``` ubuntutools/test/test_archive.py::LocalSourcePackageTestCase::test_pull /usr/lib/python3.11/unittest/case.py:678: DeprecationWarning: It is deprecated to return a value that is not None from a test case (>) return self.run(*args, **kwds) ``` `test_pull` does not need to be run directly. Make it private. Signed-off-by: Benjamin Drung --- ubuntutools/test/test_archive.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ubuntutools/test/test_archive.py b/ubuntutools/test/test_archive.py index b2a3f19..e01fa01 100644 --- a/ubuntutools/test/test_archive.py +++ b/ubuntutools/test/test_archive.py @@ -75,7 +75,7 @@ class LocalSourcePackageTestCase(BaseVerificationTestCase): srcpkg.pull() return srcpkg - def test_pull(self, **kwargs): + def _test_pull(self, **kwargs): srcpkg = self.pull(**kwargs) self.assertTrue(filecmp.cmp(self.pkg.dsc, self.workdir / self.pkg.dsc.name)) self.assertTrue(filecmp.cmp(self.pkg.orig, self.workdir / self.pkg.orig.name)) @@ -92,7 +92,7 @@ class LocalSourcePackageTestCase(BaseVerificationTestCase): self.assertTrue(debian.is_dir()) def test_pull_and_unpack(self, **kwargs): - self.test_unpack(srcpkg=self.test_pull(**kwargs)) + self.test_unpack(srcpkg=self._test_pull(**kwargs)) def test_with_package(self): self.test_pull_and_unpack(package=self.pkg.source) @@ -117,7 +117,7 @@ class LocalSourcePackageTestCase(BaseVerificationTestCase): testfile.write_bytes(corruption) self.assertEqual(testfile.read_bytes(), corruption) - self.test_pull() + self._test_pull() self.assertTrue(testfile.exists()) self.assertTrue(testfile.is_file()) self.assertNotEqual(testfile.read_bytes(), corruption)