Lubuntu/ubuntu-dev-tools
3
0
Fork 0
mirror of https://git.launchpad.net/ubuntu-dev-tools synced 2025-04-17 05:11:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix pull-revu-source help, and return 0

Browse Source
This commit is contained in:
Stefano Rivera 2010-12-22 17:14:48 +02:00
parent df6b32086b
commit 34b1991bdd
3 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
debian/changelog vendored
View File

@ -16,8 +16,9 @@ ubuntu-dev-tools (0.109) UNRELEASED; urgency=low
* Add the beginnings of a test suite. (LP: #690386)
- Switch to setuptools, to support setup.py test.
- Test for that every script can run --help and return 0.
- 404main, merge-changelog, pull-debian-debdiff, pull-debian-source:
Return 0 after showing help.
- 404main, merge-changelog, pull-debian-debdiff, pull-debian-source,
pull-revu-source:
+ Return 0 after showing help.
* ubuntutools/common.py: Remove https_proxy unsetting code, working around
LP: #94130.
@ -32,7 +33,7 @@ ubuntu-dev-tools (0.109) UNRELEASED; urgency=low
- Fix 'str' object has no attribute 'startwith' crash caused by a typo.
- Fix crash if uploading to ubuntu without building the package before.
-- Stefano Rivera <stefanor@ubuntu.com> Wed, 22 Dec 2010 16:52:55 +0200
-- Stefano Rivera <stefanor@ubuntu.com> Wed, 22 Dec 2010 17:13:59 +0200
ubuntu-dev-tools (0.108) experimental; urgency=low

9
pull-revu-source
View File

@ -20,6 +20,7 @@
use warnings;
use strict;
use File::Basename;
use LWP::Simple;
use Getopt::Long;
@ -27,10 +28,10 @@ die("Please install 'devscripts'\n") if(! grep -x "$_/dget", split(':',$ENV{'PAT
my $REVU = "revu.ubuntuwire.com";
my($package) = lc($ARGV[0]) || usage();
my($package) = lc($ARGV[0]) || usage(2);
my($help)=0;
GetOptions('help' => \$help);
usage() if($help);
usage(0) if($help);
dget(getURL());
@ -47,6 +48,8 @@ sub dget {
}
sub usage {
my($exit) = @_;
my($name)=basename($0);
die("USAGE: $name [-h] <source package>\n");
print("USAGE: $name [-h] <source package>\n");
exit($exit);
}

1
ubuntutools/test/test_help.py
View File

@ -33,7 +33,6 @@ BLACKLIST = {
'massfile': 'No Help. Leaves files in .',
'mk-sbuild': 'Fires up apt-get before showing help',
'pbuilder-dist-simple': 'No Help',
'pull-revu-source': 'Throws Error',
'setup-packaging-environment': 'Throws Error',
'submittodebian': 'No Help',
'ubuntu-iso': 'No Help',