From 430fc81aab9c0e674f0ec29ddc90d40502a209b0 Mon Sep 17 00:00:00 2001 From: Stefano Rivera Date: Fri, 25 Nov 2011 15:40:05 +0200 Subject: [PATCH] Check that there are published binaries (i.e. not stuck in bin-NEW). --- debian/changelog | 4 +++- requestbackport | 8 ++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/debian/changelog b/debian/changelog index 0fce189..b962b91 100644 --- a/debian/changelog +++ b/debian/changelog @@ -4,7 +4,9 @@ ubuntu-dev-tools (0.136ubuntu1) UNRELEASED; urgency=low * Remove dgetlp. No longer needed. * Use httplib2 everywhere that we do https. The python stdlib doesn't do certificate verification. - * requestbackport: Check for existing backport bugs first. + * requestbackport: + - Check for existing backport bugs first. + - Check that there are published binaries (i.e. not stuck in bin-NEW). * pull-lp-source, requestbackport: Take the latest version from any non-backports pocket. Implemented by making lpapicache's getSourcePackage smarter. diff --git a/requestbackport b/requestbackport index 6f90ff0..7c6a9db 100755 --- a/requestbackport +++ b/requestbackport @@ -175,6 +175,14 @@ def request_backport(package_spph, source, destinations): for bpph in package_spph.getBinaries(): published_binaries.add(bpph.getPackageName()) + if not published_binaries: + Logger.error("%s (%s) has no published binaries in %s. ", + package_spph.getPackageName(), package_spph.getVersion(), + source) + Logger.normal("Is it stuck in bin-NEW? It can't be backported until " + "the binaries have been accepted.") + sys.exit(1) + testing = [] testing += ["You can test-build the backport in your PPA with " "backportpackage:"]