From 43891eda88ccca2e06af2c08344cd0ccfb16f3f2 Mon Sep 17 00:00:00 2001 From: Chris Peterson Date: Mon, 26 Feb 2024 16:16:32 -0800 Subject: [PATCH] depends: python3-launchpadlib-desktop Replace the dependency on python3-launchpadlib with python3-launchpadlib-desktop. This package is the same as python3-launchpadlib except that it also includes python3-keyring, which is a requirement for some of the desktop-centric code-paths. In the case, requestsync has a path for logging in via a web browser which also requires python3-keyring to be installed. This had caused a ModuleNotFoundError when python3-launchpadlib dropped python3-keyring from Recommends to Suggests (LP: #2049217). --- ubuntutools/test/test_requestsync.py | 36 ++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 ubuntutools/test/test_requestsync.py diff --git a/ubuntutools/test/test_requestsync.py b/ubuntutools/test/test_requestsync.py new file mode 100644 index 0000000..09fa3c4 --- /dev/null +++ b/ubuntutools/test/test_requestsync.py @@ -0,0 +1,36 @@ +# Copyright (C) 2024 Canonical Ltd. +# Author: Chris Peterson +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU Affero General Public License as +# published by the Free Software Foundation, either version 3 of the +# License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU Affero General Public License for more details. +# +# You should have received a copy of the GNU Affero General Public License +# along with this program. If not, see . + +import unittest + + +# Binary Tests +class BinaryTests(unittest.TestCase): + + # The requestsync binary has the option of using the launchpad api + # to log in but requires python3-keyring in addition to + # python3-launchpadlib. Testing the integrated login functionality + # automatically isn't very feasbile, but we can at least write a smoke + # test to make sure the required packages are installed. + # See LP: #2049217 + def test_keyring_installed(self): + """Smoke test for required lp api dependencies""" + try: + import keyring # noqa: F401 + except ModuleNotFoundError: + raise ModuleNotFoundError( + "package python3-keyring is not installed" + )