Lubuntu/ubuntu-dev-tools
3
0
Fork 0
mirror of https://git.launchpad.net/ubuntu-dev-tools synced 2025-03-13 08:01:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

archive: deprecate poorly-named pull_dsc() method

Browse Source
This commit is contained in:
Dan Streetman 2021-05-28 16:24:15 -04:00
parent 90824e056c
commit 9be49e7b93
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ubuntutools/archive.py
View File

@ -282,7 +282,8 @@ class SourcePackage(ABC):
def dsc(self): def dsc(self):
"Return the Dsc" "Return the Dsc"
if not self._dsc: if not self._dsc:
self.pull_dsc() urls = self._source_urls(self.dsc_name)
self._download_file_from_urls(urls, self.dsc_pathname)
with open(self.dsc_pathname, 'rb') as f: with open(self.dsc_pathname, 'rb') as f:
self._dsc = Dsc(f.read()) self._dsc = Dsc(f.read())
self._check_dsc_signature() self._check_dsc_signature()
@ -408,9 +409,18 @@ class SourcePackage(ABC):
raise DownloadError('Failed to download %s' % filename) raise DownloadError('Failed to download %s' % filename)
def pull_dsc(self): def pull_dsc(self):
"Pull dscfile into workdir" '''DEPRECATED
urls = self._source_urls(self.dsc_name)
self._download_file_from_urls(urls, self.dsc_name) This method is badly named and historically has only 'pulled' the
dsc into memory, not actually to a file. Since the other 'pull' methods
actually 'pull' to real files, this method makes no sense; additionally
there is no need for this method since we can 'pull' the dsc into
memory when the .dsc property is accessed.
This method no longer does anything at all and should not be used by
anyone.
'''
Logger.debug('Please fix your program: the "pull_dsc" method is deprecated')
def pull(self): def pull(self):
"Pull into workdir" "Pull into workdir"