Run pylint during package build again

Commit ae74f71a1e9d4be043162b19d23f2d44c964c771 removed the pylint unit
test saying that unit tests are not needed to just run flake8 or pylint.

Since pylint is useful, add it back, but this time call it directly and
not embed it into a unit test.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>

.pylintrc

@@ -1,5 +1,10 @@
 [MASTER]
 
+# A comma-separated list of package or module names from where C extensions may
+# be loaded. Extensions are loading into the active Python interpreter and may
+# run arbitrary code.
+extension-pkg-allow-list=apt_pkg
+
 # Pickle collected data for later comparisons.
 persistent=no
 
@@ -22,7 +27,7 @@ confidence=HIGH
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use"--disable=all --enable=classes
 # --disable=W"
-disable=locally-disabled
+disable=fixme,locally-disabled,missing-docstring
 
 
 [REPORTS]
@@ -31,14 +36,6 @@ disable=locally-disabled
 reports=no
 
 
-[TYPECHECK]
-
-# List of classes names for which member attributes should not be checked
-# (useful for classes with attributes dynamically set).
-# lpapicache classes, urlparse
-ignored-classes=Launchpad,BaseWrapper,PersonTeam,Distribution,Consumer,Credentials,ParseResult,apt_pkg,apt_pkg.Dependency,apt_pkg.BaseDependency
-
-
 [FORMAT]
 
 # Maximum number of characters on a single line.
@@ -52,4 +49,10 @@ indent-string='    '
 [BASIC]
 
 # Allow variables called e, f, lp
-good-names=i,j,k,ex,Run,_,e,f,lp
+good-names=i,j,k,ex,Run,_,e,f,lp,me,to
+
+
+[IMPORTS]
+
+# Force import order to recognize a module as part of a third party library.
+known-third-party=debian

debian/control

@@ -17,6 +17,7 @@ Build-Depends:
  flake8,
  isort <!nocheck>,
  lsb-release,
+ pylint <!nocheck>,
  python3-all,
  python3-apt,
  python3-debian,

debian/copyright

@@ -176,7 +176,8 @@ Files: doc/pull-debian-debdiff.1
        ubuntutools/update_maintainer.py
        ubuntutools/version.py
        update-maintainer
-Copyright: 2009-2011, Benjamin Drung <bdrung@ubuntu.com>
+       .pylintrc
+Copyright: 2009-2023, Benjamin Drung <bdrung@ubuntu.com>
            2010,      Evan Broder <evan@ebroder.net>
            2008,      Siegfried-Angel Gevatter Pujals <rainct@ubuntu.com>
            2010-2011, Stefano Rivera <stefanor@ubuntu.com>

run-linters

@@ -14,3 +14,6 @@ isort --check-only --diff .
 
 echo "Running flake8..."
 flake8 --max-line-length=99 --ignore=E203,W503 . $PYTHON_SCRIPTS
+
+echo "Running pylint..."
+pylint $(find * -name '*.py') $PYTHON_SCRIPTS