From ac53f8f76730470ead9eb9c5ffcbd615ac867be8 Mon Sep 17 00:00:00 2001 From: Colin Watson Date: Tue, 9 Jun 2009 11:00:55 +0100 Subject: [PATCH] Get rid of the last remaining use of subprocess.Popen(shell=True) in 404main. --- 404main | 2 +- debian/changelog | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/404main b/404main index f73623e..e3f93d9 100755 --- a/404main +++ b/404main @@ -123,7 +123,7 @@ def main(): print 'Remember that for 404main to work with a certain distribution it must be in your /etc/apt/sources.list file.' sys.exit(1) else: - distro = subprocess.Popen('lsb_release -cs', shell=True, stdout=subprocess.PIPE).stdout.read().strip('\n') + distro = subprocess.Popen(['lsb_release', '-cs'], stdout=subprocess.PIPE).stdout.read().strip('\n') if not get_package_version(cache, distro, sys.argv[1]): print 'Can\'t find package «%s» in distribution «%s».' % (sys.argv[1], distro) diff --git a/debian/changelog b/debian/changelog index 4da8a4e..8c44151 100644 --- a/debian/changelog +++ b/debian/changelog @@ -38,6 +38,8 @@ ubuntu-dev-tools (0.75) UNRELEASED; urgency=low [ Colin Watson ] * Rewrite 404main using python-apt. Note that this requires python-apt 0.7.9, not in jaunty. + * Get rid of the last remaining use of subprocess.Popen(shell=True) in + 404main. -- Michael Bienia Tue, 09 Jun 2009 10:31:03 +0200