Lubuntu/ubuntu-dev-tools
3
0
Fork 0
mirror of https://git.launchpad.net/ubuntu-dev-tools synced 2025-03-12 23:51:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

archive: log warnings around 'staging' pocket

Browse Source 
The 'staging' pocket contains binaries that don't match published binaries,
so log a warning if we fallback to that pocket, and log a warning if pulling
binaries using that pocket.

Signed-off-by: Dan Streetman <ddstreet@canonical.com>
This commit is contained in:
Dan Streetman 2020-07-21 15:03:00 -04:00
parent 9a38ad1b7b
commit d8d4fd9285
1 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
ubuntutools/archive.py
View File

@ -640,14 +640,34 @@ class UbuntuCloudArchiveSourcePackage(PersonalPackageArchiveSourcePackage):
def __init__(self, *args, **kwargs):
# Need to determine actual series/pocket ppa now, as it affects getArchive()
(series, pocket) = self._findReleaseAndPocketForPackage(kwargs.pop('series', None),
kwargs.pop('pocket', None),
(series, pocket) = self._findReleaseAndPocketForPackage(kwargs.get('series'),
kwargs.get('pocket'),
kwargs.get('package'),
kwargs.get('version'))
# Drop series/pocket from kwargs, as UCA handles them completely different and we
# don't want to pass them up to the superclass
kwargs.pop('series', None)
orig_pocket = kwargs.pop('pocket', None)
if orig_pocket and orig_pocket != pocket and pocket == 'staging':
Logger.info(f"Ubuntu Cloud Archive release '{series}' pocket '{orig_pocket}'"
" PPA is not public, using 'staging' pocket instead")
kwargs['ppa'] = f"{self.TEAM}/{series}-{pocket}"
super(UbuntuCloudArchiveSourcePackage, self).__init__(*args, **kwargs)
self.masters = ["http://ubuntu-cloud.archive.canonical.com/ubuntu/"]
def pull_binaries(self, arch=None, name=None, ext=None):
"""Pull binary debs into workdir.
This is only a wrapper around the superclass method, to log warning if
pulling binaries when using a 'staging' ppa, since the published binaries
will not match the 'staging' binaries.
"""
if self._ppaname.endswith('-staging'):
Logger.warning("Binaries from 'staging' pocket will not match published binaries; "
"see https://bugs.launchpad.net/cloud-archive/+bug/1649979")
return super(UbuntuCloudArchiveSourcePackage, self).pull_binaries(arch, name, ext)
@classmethod
@functools.lru_cache
def getUbuntuCloudArchiveProject(cls):