Use dpkg-vendor in ubuntutools.misc.system_distribution(), cache result.

debian/changelog

@@ -17,6 +17,7 @@ ubuntu-dev-tools (0.107) UNRELEASED; urgency=low
     - Refactor to use subprocess.popen instead of os.system (LP: #398974)
     - Catch OSErrors when creating directories (LP: #671067)
     - Set HOME so pbuilder reads .pbuilderrc
+  * Use dpkg-vendor in ubuntutools.misc.system_distribution(), cache result.
 
   [ Benjamin Drung ]
   * wrap-and-sort: Remove duplicate items from sorted lists.

ubuntutools/misc.py

@@ -26,6 +26,7 @@ from subprocess import Popen, PIPE
 
 from ubuntutools.lp.udtexceptions import PocketDoesNotExistError
 
+_system_distribution = None
 def system_distribution():
     """ system_distro() -> string
 
@@ -33,21 +34,22 @@ def system_distribution():
     name of the distribution can't be determined, print an error message
     and return None.
     """
-    # We try to avoid calling the "lsb_release" as looking up the value
+    global _system_distribution
-    # directly is faster. However, Debian doesn't have /etc/lsb-release
+    if _system_distribution is None:
-    # so we need to fallback to the former there.
+        try:
-    if os.path.isfile('/etc/lsb-release'):
+            if os.path.isfile('/usr/bin/dpkg-vendor'):
-        for line in open('/etc/lsb-release'):
+                p = Popen(('dpkg-vendor', '--query', 'vendor'), stdout=PIPE)
-            line = line.strip()
+            else:
-            if line.startswith('DISTRIB_CODENAME'):
+                p = Popen(('lsb_release', '-cs'), stdout=PIPE)
-                return line[17:]
+            output = p.communicate()[0]
-    else:
+        except OSError:
-        import commands
+            print 'Error: Could not determine what distribution you are running.'
-        output = commands.getoutput('lsb_release -cs')
+            return None
-        if output:
+        if p.returncode != 0:
-            return output
+            print 'Error determininng system distribution'
-    print 'Error: Could not determine what distribution you are running.'
+            return None
-    return None
+        _system_distribution = output.strip()
+    return _system_distribution
 
 def host_architecture():
     """ host_architecture -> string