Dan Streetman
bcf3e153f7
Fix pulling from upload queue
...
Commit 4a4c4e0a27cfd159ac0bbc135d4eff06be8bde1c completely broke
pull-lp-source --upload-queue, which now fails with:
Traceback (most recent call last):
File "/usr/bin/pull-lp-source", line 14, in <module>
PullPkg.main(distro="ubuntu", pull="source")
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/ubuntutools/pullpkg.py", line 111, in main
cls(*args, **kwargs).pull()
~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/usr/lib/python3/dist-packages/ubuntutools/pullpkg.py", line 438, in pull
self.pull_upload_queue( # pylint: disable=missing-kwoa
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pull, arch=options["arch"], download_only=options["download_only"], **params
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
Fixes LP: #2110061
2025-05-06 13:21:52 -04:00
ferbraher
4a4c4e0a27
Parsing arch parameter to getBinaryPackage()
2025-03-04 13:08:59 -06:00
Benjamin Drung
e7ba650414
Avoid unnecessary "elif" after "continue"
...
Address pylint's no-else-continue.
2024-11-02 17:55:33 +01:00
Benjamin Drung
3bc802a209
Use lazy % formatting in logging functions
2024-11-02 17:55:20 +01:00
Benjamin Drung
c7a855ff20
Format code with black and isort
...
```
isort pbuilder-dist pm-helper running-autopkgtests ubuntu-build ubuntutools
black -C pbuilder-dist pm-helper running-autopkgtests ubuntu-build ubuntutools
```
2024-11-02 17:21:30 +01:00
Simon Quigley
2f396fe549
When using pull-*-source to grab a package which already has a defined Vcs- field, display the exact same warning message apt source
does.
2023-10-03 14:01:19 -05:00
Benjamin Drung
aa556af89d
Use f-strings
...
pylint complains about C0209: Formatting a regular string which could be
a f-string (consider-using-f-string)
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
2023-01-31 19:32:58 +01:00
Benjamin Drung
444b319c12
Implement refactorings found by pylint
...
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
2023-01-31 16:58:24 +01:00
Benjamin Drung
4449cf2437
Fix warnings found by pylint
...
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
2023-01-31 15:51:29 +01:00
Benjamin Drung
f6fde2e217
fix: Use lazy % formatting in logging functions
...
pylint complains about W1201: Use lazy % formatting in logging functions
(logging-not-lazy) and W1203: Use lazy % formatting in logging functions
(logging-fstring-interpolation).
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
2023-01-31 11:13:07 +01:00
Benjamin Drung
72add78e9d
Fix errors found by pylint
...
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
2023-01-31 10:19:24 +01:00
Benjamin Drung
b1bc7e1cdc
Address pylint complaints
...
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
2023-01-30 23:10:31 +01:00
Benjamin Drung
4e27045f49
style: Sort Python imports with isort
...
```
isort -l 99 --profile=black .
```
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
2023-01-30 21:28:47 +01:00
Benjamin Drung
3354b526b5
style: Format Python code with black
...
```
PYTHON_SCRIPTS=$(grep -l -r '^#! */usr/bin/python3$' .)
black -C -l 99 . $PYTHON_SCRIPTS
```
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
2023-01-30 19:45:36 +01:00
Dan Streetman
4d72d184db
pullpkg: change pull_upload_queue params into specific keyword-only params
2021-11-19 08:11:31 -05:00
Dan Streetman
20261960f6
pullpkg: unpack downloaded src from upload queue
2021-11-19 08:11:31 -05:00
Dan Streetman
0eeb93ee0c
logging: update ubuntutools.getLogger() to output to stdout/stderr correctly
...
Python logging by default sends all output to stderr, but that's not what
normal programs usually do and is not expected for these scripts.
Change the ubuntutools.getLogger() method to return a logger with handlers
correctly set up to send INFO level (or lower) logs to stdout and WARNING
level (or higher; technically INFO+1 level or higher) logs to stderr.
This results in normally logged output going to stdout and warnings/errors
going to stderr, as expected.
2021-02-02 06:25:12 -05:00
Dan Streetman
9a38ad1b7b
archive: add UCA parsing/finding code for UCA releases/pockets
...
Signed-off-by: Dan Streetman <ddstreet@canonical.com>
2021-02-02 06:25:12 -05:00
Dan Streetman
20036e6c36
ubuntutools/pullpkg: add --login parameter
...
Just in case we want to pull from a private ppa...
Signed-off-by: Dan Streetman <ddstreet@canonical.com>
2021-02-02 06:25:12 -05:00
Dan Streetman
58ca95e719
pullpkg: provide dst to download()
...
Signed-off-by: Dan Streetman <ddstreet@canonical.com>
2021-02-02 06:25:12 -05:00
Dimitri John Ledkov
6cc8040510
pullpkg.py: fix --mirror option parsing.
2021-01-19 10:43:46 +00:00
Dan Streetman
b30df2b227
pullpkg: also catch InvalidPullValueError
...
LP: #1908770
2020-12-21 11:28:08 -05:00
Dan Streetman
8aa2d602c5
pullpkg: add support for pulling from upload queue
2020-03-13 10:02:05 -04:00
Dan Streetman
36ffc92e00
pullpkg: for -p list, show bpph arch for files built for 'all' arch
2020-02-13 17:43:24 -05:00
Dan Streetman
82c8c438f7
ubuntutools: use file extension when possible to determine deb/ddeb/udeb
2019-11-25 16:40:18 -05:00
Dan Streetman
e37e9db7eb
pullpkg: add --security param to query ubuntu sec team proposed ppa
2019-11-25 10:10:06 -05:00
Dan Streetman
87a09640ba
ubuntutools/pullpkg.py: convert -v to count, enable package-wide debug for -vv
2019-11-25 10:10:06 -05:00
Dan Streetman
90e8fe81e1
replace ubuntutools.logger with standard python logging
2019-11-25 10:10:06 -05:00
Dan Streetman
7c097b19ba
ubuntutools: add --status param to pull-pkg
...
Allow specifying what package statuses should be searched for.
By default search only for Pending and Published, unless a specific
version number is being searched for.
2019-11-25 10:10:06 -05:00
Dan Streetman
b11b83f0e2
pull-pkg: change UCA source pkg class to subclass of PPA source pkg class
...
The UCA source pkg class was its own specific class, but with the
addition of the generic PPA source pkg class, the UCA class is just
a specific case of PPA. Changing it to a subclass of the PPA class
simplifies code.
2019-11-25 10:10:06 -05:00
Dan Streetman
7084bfc8bc
pull-pkg: add pull-ppa-* functionality
...
Add functionality, and frontend pull-ppa-* scripts, to be able to pull
from PPA archives.
2019-11-25 10:10:06 -05:00
Dan Streetman
3491b0cff9
pull-pkg: change pullpkg into class PullPkg
...
instead of pullpkg.py containing a simple method to call, change it
into a normal class PullPkg that callers can create and use.
2019-11-25 10:10:06 -05:00
Dan Streetman
3a413760f3
ubuntutools: add pull-* --no-verify-signature option, don't fail if no pub key
...
Change dsc verification to fail only if the public key was available, but
signature verification failed. If no public key is available for the dsc,
print warning only. (LP: #1700846 )
Also add pull-* parameter --no-verify-signature to manually prevent failure
when signature verification fails.
2019-11-25 10:10:06 -05:00
Dan Streetman
cdaf5d0761
pull-pkg: change pull-pkg script code into modular code
2019-11-25 10:10:06 -05:00
Dan Streetman
79b705d235
pull-pkg: rename pull-pkg to ubuntutools/pullpkg.py module
...
rename only with no content changes, so next commit shows code
changes converting script pull-pkg to module pullpkg.py
This also changes the file mode from 755 to 644, since we're changing
an executable script into a module.
2019-11-25 10:09:26 -05:00