Merge branch 'recommends-sudo' of git+ssh://git.launchpad.net/~cjwatson/ubuntu-dev-tools

MR: https://code.launchpad.net/~cjwatson/ubuntu-dev-tools/+git/ubuntu-dev-tools/+merge/497980
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

debian/changelog

@@ -1,3 +1,14 @@
+ubuntu-dev-tools (0.209) UNRELEASED; urgency=medium
+
+  [ Colin Watson ]
+  * Demote sudo to Recommends, and indicate which tools need it in the
+    package description.
+
+  [ Florent 'Skia' Jacquet ]
+  * pm-helper: make use of YesNoQuestion
+
+ -- Mattia Rizzolo <mattia@debian.org>  Tue, 06 Jan 2026 17:55:43 +0100
+
 ubuntu-dev-tools (0.208) unstable; urgency=medium
 
   [ Gianfranco Costamagna ]

debian/control

@@ -60,7 +60,6 @@ Depends:
  python3-ubuntutools (= ${binary:Version}),
  python3-yaml,
  sensible-utils,
- sudo,
  tzdata,
  ${misc:Depends},
  ${perl:Depends},
@@ -77,6 +76,7 @@ Recommends:
  quilt,
  reportbug (>= 3.39ubuntu1),
  sbuild | pbuilder | cowbuilder,
+ sudo,
  ubuntu-keyring | ubuntu-archive-keyring,
 Suggests:
  bzr | brz,
@@ -93,7 +93,7 @@ Description: useful tools for Ubuntu developers
     willing to help fix it.
   - check-mir - check support status of build/binary dependencies
   - check-symbols - will compare and give you a diff of the exported symbols of
-    all .so files in a binary package.
+    all .so files in a binary package. [sudo]
   - dch-repeat - used to repeat a change log into an older release.
   - grab-merge - grabs a merge from merges.ubuntu.com easily.
   - grep-merges - search for pending merges from Debian.
@@ -101,9 +101,10 @@ Description: useful tools for Ubuntu developers
   - merge-changelog - manually merges two Debian changelogs with the same base
     version.
   - mk-sbuild - script to create LVM snapshot chroots via schroot and
-    sbuild.
+    sbuild. [sbuild, sudo]
   - pbuilder-dist, cowbuilder-dist - wrapper script for managing several build
     chroots (for different Ubuntu and Debian releases) on the same system.
+    [pbuilder | cowbuilder, sudo]
   - pull-debian-debdiff - attempts to find and download a specific version of
     a Debian package and its immediate parent to generate a debdiff.
   - pull-debian-source - downloads the latest source package available in
@@ -123,7 +124,7 @@ Description: useful tools for Ubuntu developers
     autopkgtests on the Ubuntu autopkgtest infrastructure
   - seeded-in-ubuntu - query if a package is safe to upload during a freeze.
   - setup-packaging-environment - assistant to get an Ubuntu installation
-    ready for packaging work.
+    ready for packaging work. [sudo]
   - sponsor-patch - Downloads a patch from a Launchpad bug, patches the source
     package, and uploads it (to Ubuntu or a PPA)
   - submittodebian - automatically send your changes to Debian as a bug report.

pm-helper

@@ -22,6 +22,7 @@ from argparse import ArgumentParser
 import yaml
 from launchpadlib.launchpad import Launchpad
 
+from ubuntutools.question import YesNoQuestion
 from ubuntutools.utils import get_url
 
 # proposed-migration is only concerned with the devel series; unlike other
@@ -56,10 +57,8 @@ def claim_excuses_bug(launchpad, bug, package):
     if our_task.assignee:
         print(f"Currently assigned to {our_task.assignee.name}")
 
-    print("""Do you want to claim this bug? [yN] """, end="")
-    sys.stdout.flush()
-    response = sys.stdin.readline()
-    if response.strip().lower().startswith("y"):
+    answer = YesNoQuestion().ask("Do you want to claim this bug?", "no")
+    if answer == "yes":
         our_task.assignee = launchpad.me
         our_task.lp_save()
         return True
@@ -131,6 +130,8 @@ def main():
                 if not proposed_version:
                     print(f"Package {args.package} not found in -proposed.")
                     sys.exit(1)
+                answer = YesNoQuestion().ask("Do you want to create a bug?", "no")
+                if answer == "yes":
                     create_excuses_bug(args.launchpad, args.package, proposed_version)
         except ValueError as e:
             sys.stderr.write(f"{e}\n")