1388 Commits

Author SHA1 Message Date
Niels Thykier
c0ecdd82fb
Remove now redundant APIs from the InstallabilityTester
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-11-11 09:38:13 +00:00
Niels Thykier
0a669461ca
Separate inst_tester from universe
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-11-11 09:38:12 +00:00
Niels Thykier
35b06ee007
tests: Separate inst_tester from universe
This commit updates the test suite to use the BinaryPackageUniverse
instead of the InstallabilityTester where that makes sense.  The rest
of Britney has yet to be updated except where absolutely necessary (as
that will come in a later commit).

Signed-off-by: Niels Thykier <niels@thykier.net>
2018-11-11 09:38:11 +00:00
Niels Thykier
d557610c6f
BinaryPackageUniverse: Implement packages_equivalent_to()
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-11-11 09:38:10 +00:00
Niels Thykier
530db5d3f7
Extract a BinaryPackageUniverse from the InstallabilityTester
The InstallabilityTester is suffering from a lack of clear purpose
because it serves multiple.  This commit extracts most of one of these
purposes into the BinaryPackageUniverse class while retaining the
original API of the InstallabilityTester.

Signed-off-by: Niels Thykier <niels@thykier.net>
2018-11-11 09:38:09 +00:00
Niels Thykier
b7fe352713
britney.conf: Bump autopkgtest regression deadline by 2 days
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-11-11 09:37:11 +00:00
Niels Thykier
a1df601c04
britney.conf: Bump autopkgtest regression deadline by 2 days
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-11-04 20:03:58 +00:00
Niels Thykier
32def47991
Fix typo in doc string
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-11-01 21:30:25 +00:00
Niels Thykier
b37575f000
Stop creating some throw-away data-structures for a method call
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-11-01 21:30:24 +00:00
Niels Thykier
f86cda97da
inst_tester: Improve doc string/argument name
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-11-01 21:30:23 +00:00
Paul Gevers
32ea0ccb70
tests: naming of variables in test_policy:apply_policy is highly confusing 2018-11-01 15:22:02 +01:00
Ivo De Decker
b839e1a459
Ignore dependencies of cruft when building excuses.
Don't make dependencies of cruft a blocker for being a candidate. In most
cases, the cruft won't migrate to testing, so it shouldn't be a blocker. If
the cruft would be considered for migration to testing, the installability
check will catch missing deps.

Signed-off-by: Ivo De Decker <ivodd@debian.org>
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-10-30 19:40:37 +00:00
Niels Thykier
7cdf10bc77
Inline get_nuninst into its remaining callees
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-10-28 21:37:41 +00:00
Niels Thykier
05aaf1cc12
Refactor nuninst initialization to avoid reading the cache from disk
At the moment, britney will always read the nuncache from disk
(possibly regenerating it before reading it).  However, we can save
the "read from disk" by moving the initialization of nuninst into the
constructor of Britney and relying on clone_nuninst.

Signed-off-by: Niels Thykier <niels@thykier.net>
2018-10-28 21:35:18 +00:00
Niels Thykier
7bcbcb6282
Make clone_nuninst able to fully deep clone nuninst
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-10-28 21:26:48 +00:00
Niels Thykier
bd0a96553c
britney.conf: Bump autopkgtest regression deadline by 2 days 2018-10-28 17:48:08 +00:00
Niels Thykier
7df8cc3ae3
doc/hints.rst: Fix a warning from sphinx-build
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-10-25 20:14:33 +00:00
Niels Thykier
6c5300d873
Unfold the suite.binaries tuple into two members
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-10-25 18:34:41 +00:00
Ivo De Decker
9c606ef533 Don't add smooth-updatable cruft to migration items
Based on patch by Niels Thykier.

Signed-off-by: Ivo De Decker <ivodd@debian.org>
2018-10-24 22:15:27 +00:00
Paul Gevers
b752bdea07
Document force-badtest and force-skiptest 2018-10-23 21:58:24 +02:00
Niels Thykier
480516f6af
britney.conf: Bump autopkgtest regression deadline by 2 days
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-10-20 05:17:59 +00:00
Niels Thykier
ba3ca4d092
britney.conf: Bump autopkgtest regression deadline by 2 days
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-10-14 06:23:22 +00:00
Niels Thykier
9564b1b6d6
britney.conf: Bump autopkgtest regression deadline by 2 days 2018-10-08 05:22:22 +00:00
Niels Thykier
edfe40d69c
Fix and re-add a test
Thanks: Paul Gevers <elbrus@debian.org>
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-10-03 05:35:48 +00:00
Niels Thykier
712b618ee8
tests: Comment out test requiring "do_test" function
It does not exist in the Debian version (yet?).

Signed-off-by: Niels Thykier <niels@thykier.net>
2018-10-01 19:48:07 +00:00
Niels Thykier
99a35a2986
autopkgtest.py: Update previous commit to match recent changes
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-10-01 19:46:43 +00:00
Iain Lane
c09a229dc9
autopkgtest: Run gcc-n's testuite, if it has one 2018-10-01 19:22:29 +00:00
Niels Thykier
7fd15eab4f
britney: Use chain rather then duplicate statement
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 16:31:21 +00:00
Niels Thykier
e279eabf0a
britney.py: Remove duplicated variable
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 16:03:02 +00:00
Niels Thykier
f561de89d0
britney.py: Remove an unnecessary level of indentation
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:57:07 +00:00
Niels Thykier
880a614b2b
britney: Extract a find_smooth_updateable_binaries function
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:57:06 +00:00
Niels Thykier
7d7a42153d
britney.py: Simply a loop in should_upgrade_src
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:19:39 +00:00
Niels Thykier
c4931fb1b2
solver: Move a common variable out of an if
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:19:38 +00:00
Niels Thykier
1e46965924
inst/builder.py: Split function in three to reduce indentation levels
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:19:37 +00:00
Niels Thykier
dd5211d55a
inst-tester: Add missing element to a set
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:19:36 +00:00
Niels Thykier
55dd190fa6
inst-tester: Make "check" a list
Should be slightly cheaper (O(1)) than using a set.

Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:19:35 +00:00
Niels Thykier
cd1f384012
inst-tester: Remove obsolete "safe-set" optimization
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:19:34 +00:00
Niels Thykier
95b945d2b3
inst-tester: Remove obsolete optimization
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:19:34 +00:00
Niels Thykier
0690a85fe0
excuse: Avoid some unnecessary throw-away tuples
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:19:33 +00:00
Niels Thykier
bd1a0ea000
excuse: Fix some minor style/pep8 issues
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:19:32 +00:00
Niels Thykier
41f4b43f2c
excuse.p: Refactor some duplicated code
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:19:31 +00:00
Niels Thykier
eb64347eee
.codeclimate.yml: Update thresholds for maintainability
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 12:19:30 +00:00
Niels Thykier
7c7177a9fd
britney.conf: Bump autopkgtest regression deadline by 2 days
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-09-30 07:10:21 +00:00
Paul Gevers
18633e275c
autopkgtest: figure out which packages from unstable are needed
Currently autopkgtest tries to install our trigger from unstable and the rest
from testing. If that fails, than autopkgtest has a fall-back to allow all
packages from unstable to be installed. This has two severe issues:

1) the version of the test and the package it came from may be out-of-sync

2) too much from unstable may be installed, even stuff that should not/is not
allowed to migrate as it breaks stuff.

Make sure that test depends also get added to triggers if they are broken.
E.g. imagine the following scenario: trigger X changes (breaks) the output
generated by Y. Package Z has Y in the test dependencies and compares the
output in the autopkgtest. We want to have the opportunity that a new version
is automatically fixing the situation.

Two use cases are currently unsupported: needs-build (autopkgtest restriction)
and test dependencies generated by autodep8.
2018-09-05 21:37:23 +02:00
Paul Gevers
713b98ad6b
inst_tester: add is_pkg_in_testing 2018-09-05 21:27:41 +02:00
Paul Gevers
20a64cadef
Process space separated triggers individually 2018-08-30 16:11:24 +02:00
Niels Thykier
b6888c2716 test-builder: Avoid allocating empty throw-away lists on empty relations
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-08-12 14:38:36 +00:00
Niels Thykier
373f7f51f3 inst-builder: Avoid some hash-look ups by doing them early
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-08-12 14:02:29 +00:00
Niels Thykier
35add7cb26 Move loop-invariant out of loop
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-08-12 13:50:22 +00:00
Niels Thykier
02001d4d4f inst-builder: Loop over values instead of keys + hash-lookup
Signed-off-by: Niels Thykier <niels@thykier.net>
2018-08-12 13:18:43 +00:00