Summary:
We were using password checking in Calamares, especially as supported by libpwquality, but have received overwhelming community feedback against this. Therefore, we remove any checking by libpwquality, including defaults that aren't explicit, like the dictionary check. Sadly, it seems that setting enforcing=0 to simply print a warning does not work. IIt's possible that this is a bug, but not worth chasing at this point. The only thing unsupported is a blank password, but that's something that's [not clear](https://github.com/calamares/calamares/issues/790#issuecomment-330455711) is supported.
The good news is that the [string](743c19d8dd/src/modules/users/page_usersetup.ui (L440)) suggesting a good password is still there. If there's anywhere to be additional improments, it's there.
Test Plan: Run Calamares and enter a variety of lame passwords (e.g. space, the number one, the letter a, the word cat, etc.) twice. If the "next" button is not greyed out, it succeeds.
Reviewers: tsimonq2
Reviewed By: tsimonq2
Differential Revision: https://phab.lubuntu.me/D12
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
as published by the Free Software Foundation; either version 3
of the License, or (at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this software. If not, see http://www.gnu.org/licenses/.
Walter Lapchynski
fcc2036633