Lubuntu/installer-prompt
10
0
Fork 1
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Fix Wi-Fi spelling and minor cleanup #6

Open
NaniNoni wants to merge 2 commits from NaniNoni/installer-prompt:fix_wifi_spelling into ubuntu/noble
pull from: NaniNoni/installer-prompt:fix_wifi_spelling
merge into: Lubuntu:ubuntu/noble
Conversation 0 Commits 2 Files Changed 3 +16 -17
NaniNoni commented 2024-02-17 17:15:48 +00:00
Member
Copy Link

This PR fixes the spelling of the word 'Wi-Fi' in the following ways:

  • if the name is camel case and starts with Wi-Fi : wifiSomething
  • if not camel case: SomethingWifi or WifiSomething, e.g., in enum variants.
  • if it's in the middle of a variable name: somethingWifi
    This is also the way KF5 spells it in networkmanager-qt.
  • if it's in a string, spell it correctly: "Wi-Fi"

I also removed an unused function in the installerprompt.h header.

This PR fixes the spelling of the word 'Wi-Fi' in the following ways: - if the name is camel case and starts with Wi-Fi : `wifiSomething` - if not camel case: `SomethingWifi` or `WifiSomething`, e.g., in enum variants. - if it's in the middle of a variable name: `somethingWifi` This is also the way KF5 spells it in networkmanager-qt. - if it's in a string, spell it correctly: `"Wi-Fi"` I also removed an unused function in the `installerprompt.h` header.
NaniNoni added 2 commits 2024-02-17 17:15:48 +00:00
This pull request has changes conflicting with the target branch.
  • src/installerprompt.cpp
  • src/installerprompt.h
  • src/installerprompt.ui
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix_wifi_spelling:NaniNoni-fix_wifi_spelling
git checkout NaniNoni-fix_wifi_spelling
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
A non issue but something related to the project such as a discussion on a feature.
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Lubuntu/installer-prompt#6
No description provided.
Delete Branch "NaniNoni/installer-prompt:fix_wifi_spelling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?