Lubuntu
/
installer-prompt
10
0
Fork 2
Code Issues Pull Requests 2 Projects Releases Wiki Activity
Labels Milestones

Fix Wi-Fi spelling and minor cleanup #6

Open
NaniNoni wants to merge 2 commits from NaniNoni/installer-prompt:fix_wifi_spelling into ubuntu/noble
Conversation 0 Commits 2 Files Changed 3
NaniNoni commented 11 months ago

This PR fixes the spelling of the word 'Wi-Fi' in the following ways:

  • if the name is camel case and starts with Wi-Fi : wifiSomething
  • if not camel case: SomethingWifi or WifiSomething, e.g., in enum variants.
  • if it's in the middle of a variable name: somethingWifi
    This is also the way KF5 spells it in networkmanager-qt.
  • if it's in a string, spell it correctly: "Wi-Fi"

I also removed an unused function in the installerprompt.h header.

This PR fixes the spelling of the word 'Wi-Fi' in the following ways: - if the name is camel case and starts with Wi-Fi : `wifiSomething` - if not camel case: `SomethingWifi` or `WifiSomething`, e.g., in enum variants. - if it's in the middle of a variable name: `somethingWifi` This is also the way KF5 spells it in networkmanager-qt. - if it's in a string, spell it correctly: `"Wi-Fi"` I also removed an unused function in the `installerprompt.h` header.
NaniNoni added 2 commits 11 months ago
This pull request has changes conflicting with the target branch.
src/installerprompt.cpp
src/installerprompt.h
src/installerprompt.ui
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong meta
A non issue but something related to the project such as a discussion on a feature. question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid meta question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Lubuntu/installer-prompt#6
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'NaniNoni/installer-prompt:fix_wifi_spelling'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes