Invoke setEnabled less, which will help with resource usage

It is slightly more resource efficient to create a local bool, update that one-way flag when needed, and then setEnabled based on the content of that bool, than it would be to call that method every time.
tsimonq2/null-packages-fix
Simon Quigley 11 months ago
parent 5da00ab878
commit 8cebb36a9c

@ -43,9 +43,10 @@ void MainWindow::setUpdateInfo(QList<QStringList> updateInfo)
ui->closeButton->setEnabled(true); ui->closeButton->setEnabled(true);
ui->installButton->setEnabled(false); // Correct, it starts out false, we turn it to true if there are any updates. ui->installButton->setEnabled(false); // Correct, it starts out false, we turn it to true if there are any updates.
bool installEnabled = false;
for (int i = 0;i < 4;i++) { for (int i = 0;i < 4;i++) {
if (updateInfo[i].count() > 0) { if (updateInfo[i].count() > 0) {
ui->installButton->setEnabled(true); installEnabled = true;
} }
QTreeWidgetItem *installItem; QTreeWidgetItem *installItem;
@ -74,6 +75,8 @@ void MainWindow::setUpdateInfo(QList<QStringList> updateInfo)
ui->statLabel->setText(QString("%1 package(s) will be updated. %2 of these updates are security-related.") ui->statLabel->setText(QString("%1 package(s) will be updated. %2 of these updates are security-related.")
.arg(QString::number(updateInfo[0].count() + updateInfo[1].count() + updateInfo[2].count()), .arg(QString::number(updateInfo[0].count() + updateInfo[1].count() + updateInfo[2].count()),
QString::number(updateInfo[4].count()))); QString::number(updateInfo[4].count())));
ui->installButton->setEnabled(installEnabled);
} }
bool MainWindow::isLockedOpen() bool MainWindow::isLockedOpen()

Loading…
Cancel
Save