Labels Milestones

"Packages to be held back" is still shown #2

Closed

tsimonq2 wants to merge 3 commits from tsimonq2/null-packages-fix into ubuntu/noble

pull from: tsimonq2/null-packages-fix

merge into: Lubuntu:ubuntu/noble

Lubuntu:ubuntu/oracular

Lubuntu:ubuntu/noble

Conversation 3 Commits 3 Files Changed 1

tsimonq2 commented 11 months ago

Collaborator

and other code sanity tidbits

 and other code sanity tidbits

image.png

28 KiB

arraybolt3 was assigned by tsimonq2 11 months ago

tsimonq2 added 3 commits 11 months ago

8cebb36a9c Invoke setEnabled less, which will help with resource usage ...

It is slightly more resource efficient to create a local bool, update that one-way flag when needed, and then setEnabled based on the content of that bool, than it would be to call that method every time.

cae134166b Instead of calling the count() method every time, assign to a variable ...

It's just a little cleaner to read this way

45e3835a55 If there are no packages to consider, do not go further

arraybolt3 commented 11 months ago

Collaborator

I may simply be blind or tired, but I can't figure out how any of these changes actually fix the highlighted issue. I'm +1 on all the changes, but did something possibly get missed here?

edit: Nevermind, I am blind. Just figured it out.

I may simply be blind or tired, but I can't figure out how any of these changes actually fix the highlighted issue. I'm +1 on all the changes, but did something possibly get missed here? edit: Nevermind, I am blind. Just figured it out.

arraybolt3 commented 11 months ago

Collaborator

ok, well, +1 on most of the changes - you left a setEnabled call in commit 8cebb36a9c that you probably intended to remove :) but I get the idea of what you were doing there and can add it in.

ok, well, +1 on *most* of the changes - you left a setEnabled call in commit 8cebb36a9c that you probably intended to remove :) but I get the idea of what you were doing there and can add it in.

arraybolt3 referenced this issue from a commit 11 months ago

Manually incorporate changes from PR #2

arraybolt3 commented 11 months ago

Collaborator

Manually merged everything. Thanks!

Manually merged everything. Thanks!

arraybolt3 closed this pull request 11 months ago

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong meta
A non issue but something related to the project such as a discussion on a feature. question
More information is needed wontfix
This won't be fixed

No Label bug duplicate enhancement help wanted invalid meta question wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

arraybolt3

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Lubuntu/lubuntu-update#2

Write Preview

Loading…

Cancel

Save

There is no content yet.